deb-manila/migration-access-fix-71a0f52ea7a152a3.yaml at af79b9f5b78be5413bc363cbf12ae8351b9e4f02 - deb-manila - OpenDev: Free Software Needs Free Tools

openstack/deb-manila

Rodrigo Barbieri 10487a14a3 Fix allow/deny error message and race in migration

Share migration code [1] merged in newton intending to allow admins
to mount the share between phase1 and phase2, but API code for
allow_access and deny_access was set incorrectly, blocking it.

After discussing this feature's purpose further, we decided we do
not want this feature at this moment, so we are just fixing the
allow_access and deny_access error messages.

Also, addressed a small case of concurrency that was happening
once in a while in CI. Update_access was being invoked while
other rules were being applied, thus setting the access_rule_state
to "UPDATING_MULTIPLE", ignoring the migration access rule change
RPC request completely, failing migration. By refreshing the
model we are able to assign the proper access_rule_state at the
time the function is invoked, setting the access_rule_state
correctly.

[1] If4bfaf7e9d963b83c13a6fea241c2eda14f7f409

APIImpact

Closes-bug: #1623051
Closes-bug: #1623052

Change-Id: I76a7d8c3bdd597b951e700350f8f3f82bfb21e03

2016-09-13 13:09:17 -03:00

8 lines

240 B

YAML

Raw Blame History

 ---
 fixes:
   - Fixed access_allow and access_deny displaying incorrect error
     message during migration of a share.
   - Fixed access rule concurrency in migration that was preventing
     new rules from being added to the migrated share.