openstack/deb-murano
Code Issues Proposed changes

Fix incorrect ICMP rule in SecurityGroup

Browse Source 
When protocol is ICMP in security group, port_range_min and
port_range_max are used to indicate type and code for ICMP. The
default port setting in core library generates ICMP rule with
incorrect setting 'icmptype 0 code 0', which make user cannot ping
instance created by Murano environment. So removed them.

Change-Id: I93b5073db2ece804e3eccdde8432216d4fb12301
Closes-Bug: #1512710
This commit is contained in:
Lin Yang 2016-03-01 10:59:06 +08:00
parent 88c1b3fc32
commit 47b406d603
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
meta/io.murano/Classes/system/NeutronSecurityGroupManager.yaml
View File

@ -79,9 +79,7 @@ Methods:
properties: properties:
description: format('Composite security group of Murano environment {0}', $.environment.name) description: format('Composite security group of Murano environment {0}', $.environment.name)
rules: rules:
- port_range_min: null - protocol: icmp
port_range_max: null
protocol: icmp
remote_ip_prefix: '0.0.0.0/0' remote_ip_prefix: '0.0.0.0/0'
- $.environment.stack.updateTemplate($template) - $.environment.stack.updateTemplate($template)