From 05a0944670809be8fd3b458238a5016b5fa1b2ab Mon Sep 17 00:00:00 2001 From: Omar Shykhkerimov Date: Tue, 6 Sep 2016 16:30:23 +0300 Subject: [PATCH] Call addGroupingress() in init of NeutronSecurityGroupManager If createDefaultInstanceSecurityGroupRules() method isn't extended in its inheritors and SecurityGroups isn't created in application with addGroupIngress() then no SecurityGroup is created by default. It causes error in the NeutronNetworkBase class in its joinInstanceToNetwork() method, which always attempt to update the OS::Neutron::Port resource with a SecurityGroup attribute. This patch fixes it. Change-Id: I126e81e653799a83211e608df7409f9a0672dfed Closes-bug: #1602360 --- .../Classes/system/NeutronSecurityGroupManager.yaml | 1 + .../notes/add-default-security-group-78855a66b960840a.yaml | 6 ++++++ 2 files changed, 7 insertions(+) create mode 100644 releasenotes/notes/add-default-security-group-78855a66b960840a.yaml diff --git a/meta/io.murano/Classes/system/NeutronSecurityGroupManager.yaml b/meta/io.murano/Classes/system/NeutronSecurityGroupManager.yaml index a8690aff..e7454f1e 100644 --- a/meta/io.murano/Classes/system/NeutronSecurityGroupManager.yaml +++ b/meta/io.murano/Classes/system/NeutronSecurityGroupManager.yaml @@ -23,6 +23,7 @@ Methods: Body: - $._environment: $.find(std:Environment) - $._region: $.find(std:CloudRegion).require() + - $.addGroupIngress() addGroupIngress: Arguments: diff --git a/releasenotes/notes/add-default-security-group-78855a66b960840a.yaml b/releasenotes/notes/add-default-security-group-78855a66b960840a.yaml new file mode 100644 index 00000000..3e143d23 --- /dev/null +++ b/releasenotes/notes/add-default-security-group-78855a66b960840a.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - added default rules to NeutronSecurityGroupManager to avoid + error if `createDefaultInstanceSecurityGroupRules()` method isn't + extended in inheritor and SecurityGroups isn't created in application + with call of `addGroupIngress()` method. \ No newline at end of file