openstack/deb-murano
Code Issues Proposed changes

Merge "Add tenant_id check for {env_id}/lastStatus api"

Browse Source
This commit is contained in:
Jenkins 2015-09-02 12:04:42 +00:00 committed by Gerrit Code Review
commit fe052f9461
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
murano/api/v1/environments.py
View File

@ -154,6 +154,7 @@ class Controller(object):
sessions_controller.deploy(request, environment_id, session_id)
@request_statistics.stats_count(API_NAME, 'LastStatus')
@verify_env
def last(self, request, environment_id):
session_id = None
if hasattr(request, 'context') and request.context.session:

9
murano/tests/unit/api/v1/test_environments.py
View File

@ -279,6 +279,15 @@ class TestEnvironmentApi(tb.ControllerTest, tb.MuranoApiTestCase):
self.assertTrue(('User is not authorized to access these'
' tenant resources') in result.body)
def test_get_last_status_of_different_tenant(self):
"""Test get last services status of env belongs to another tenant."""
self._create_fake_environment('env1', '111')
req = self._get('/environments/111/lastStatus', tenant='not_match')
result = req.get_response(self.api)
self.assertEqual(403, result.status_code)
self.assertTrue(('User is not authorized to access these'
' tenant resources') in result.body)
def _create_fake_environment(self, env_name='my-env', env_id='123'):
fake_now = timeutils.utcnow()
expected = dict(