4da3b5751a
This commit modifies cleanup method of API package loader to include cleaning up of stale downloaded packages. This is done with respect to IPC and green-thread usage locks. Implements blueprint: murano-engine-package-cache Change-Id: I09a08c3646c32666893b5ed35463f8ec5e413284
481 lines
18 KiB
Python
481 lines
18 KiB
Python
# Copyright (c) 2014 Mirantis Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
|
|
# implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import collections
|
|
import itertools
|
|
import os
|
|
import os.path
|
|
import shutil
|
|
import sys
|
|
import tempfile
|
|
import uuid
|
|
|
|
import eventlet
|
|
from muranoclient.common import exceptions as muranoclient_exc
|
|
from oslo_config import cfg
|
|
from oslo_log import log as logging
|
|
import six
|
|
|
|
from murano.common.i18n import _LE, _LI
|
|
from murano.dsl import constants
|
|
from murano.dsl import exceptions
|
|
from murano.dsl import helpers
|
|
from murano.dsl import package_loader
|
|
from murano.engine import murano_package
|
|
from murano.engine.system import system_objects
|
|
from murano.engine import yaql_yaml_loader
|
|
from murano.packages import exceptions as pkg_exc
|
|
from murano.packages import load_utils
|
|
from murano import utils as m_utils
|
|
|
|
CONF = cfg.CONF
|
|
LOG = logging.getLogger(__name__)
|
|
|
|
download_mem_locks = collections.defaultdict(m_utils.ReaderWriterLock)
|
|
usage_mem_locks = collections.defaultdict(m_utils.ReaderWriterLock)
|
|
|
|
|
|
class ApiPackageLoader(package_loader.MuranoPackageLoader):
|
|
def __init__(self, murano_client_factory, tenant_id, root_loader=None):
|
|
self._cache_directory = self._get_cache_directory()
|
|
self._murano_client_factory = murano_client_factory
|
|
self.tenant_id = tenant_id
|
|
self._class_cache = {}
|
|
self._package_cache = {}
|
|
self._root_loader = root_loader or self
|
|
|
|
self._mem_locks = []
|
|
self._ipc_locks = []
|
|
self._downloaded = []
|
|
|
|
def load_class_package(self, class_name, version_spec):
|
|
packages = self._class_cache.get(class_name)
|
|
if packages:
|
|
version = version_spec.select(six.iterkeys(packages))
|
|
if version:
|
|
return packages[version]
|
|
|
|
filter_opts = {'class_name': class_name,
|
|
'version': helpers.breakdown_spec_to_query(
|
|
version_spec)}
|
|
try:
|
|
package_definition = self._get_definition(filter_opts)
|
|
self._lock_usage(package_definition)
|
|
except LookupError:
|
|
exc_info = sys.exc_info()
|
|
raise (exceptions.NoPackageForClassFound(class_name),
|
|
None, exc_info[2])
|
|
return self._to_dsl_package(
|
|
self._get_package_by_definition(package_definition))
|
|
|
|
def load_package(self, package_name, version_spec):
|
|
packages = self._package_cache.get(package_name)
|
|
if packages:
|
|
version = version_spec.select(six.iterkeys(packages))
|
|
if version:
|
|
return packages[version]
|
|
|
|
filter_opts = {'fqn': package_name,
|
|
'version': helpers.breakdown_spec_to_query(
|
|
version_spec)}
|
|
try:
|
|
package_definition = self._get_definition(filter_opts)
|
|
self._lock_usage(package_definition)
|
|
except LookupError:
|
|
exc_info = sys.exc_info()
|
|
six.reraise(exceptions.NoPackageFound(package_name),
|
|
None, exc_info[2])
|
|
return self._to_dsl_package(
|
|
self._get_package_by_definition(package_definition))
|
|
|
|
def register_package(self, package):
|
|
for name in package.classes:
|
|
self._class_cache.setdefault(name, {})[package.version] = package
|
|
self._package_cache.setdefault(package.name, {})[
|
|
package.version] = package
|
|
|
|
@staticmethod
|
|
def _get_cache_directory():
|
|
base_directory = (
|
|
CONF.packages_opts.packages_cache or
|
|
os.path.join(tempfile.gettempdir(), 'murano-packages-cache')
|
|
)
|
|
|
|
if CONF.packages_opts.enable_packages_cache:
|
|
directory = os.path.abspath(base_directory)
|
|
else:
|
|
directory = os.path.abspath(os.path.join(base_directory,
|
|
uuid.uuid4().hex))
|
|
|
|
if not os.path.isdir(directory):
|
|
m_utils.ensure_tree(directory)
|
|
|
|
LOG.debug('Cache for package loader is located at: {dir}'.format(
|
|
dir=directory))
|
|
return directory
|
|
|
|
def _get_definition(self, filter_opts):
|
|
filter_opts['catalog'] = True
|
|
try:
|
|
packages = list(self._murano_client_factory().packages.filter(
|
|
**filter_opts))
|
|
if len(packages) > 1:
|
|
LOG.debug('Ambiguous package resolution: more then 1 package '
|
|
'found for query "{opts}", will resolve based on the'
|
|
' ownership'.format(opts=filter_opts))
|
|
return self._get_best_package_match(packages)
|
|
elif len(packages) == 1:
|
|
return packages[0]
|
|
else:
|
|
LOG.debug('There are no packages matching filter '
|
|
'{filter}'.format(optst=filter_opts))
|
|
raise LookupError()
|
|
except muranoclient_exc.HTTPException:
|
|
LOG.debug('Failed to get package definition from repository')
|
|
raise LookupError()
|
|
|
|
def _to_dsl_package(self, app_package):
|
|
dsl_package = murano_package.MuranoPackage(
|
|
self._root_loader, app_package)
|
|
for name in app_package.classes:
|
|
dsl_package.register_class(
|
|
(lambda cls: lambda: get_class(app_package, cls))(name),
|
|
name)
|
|
if app_package.full_name == constants.CORE_LIBRARY:
|
|
system_objects.register(dsl_package)
|
|
self.register_package(dsl_package)
|
|
return dsl_package
|
|
|
|
def _get_package_by_definition(self, package_def):
|
|
package_id = package_def.id
|
|
package_directory = os.path.join(
|
|
self._cache_directory,
|
|
package_def.fully_qualified_name,
|
|
getattr(package_def, 'version', '0.0.0'),
|
|
package_id)
|
|
|
|
if os.path.isdir(package_directory):
|
|
try:
|
|
return load_utils.load_from_dir(package_directory)
|
|
except pkg_exc.PackageLoadError:
|
|
LOG.exception(
|
|
_LE('Unable to load package from cache. Clean-up.'))
|
|
shutil.rmtree(package_directory, ignore_errors=True)
|
|
|
|
# the package is not yet in cache, let's try and download it.
|
|
download_lock_path = os.path.join(
|
|
self._cache_directory, '{}_download.lock'.format(package_id))
|
|
download_ipc_lock = m_utils.ExclusiveInterProcessLock(
|
|
path=download_lock_path, sleep_func=eventlet.sleep)
|
|
|
|
with download_mem_locks[package_id].write_lock(),\
|
|
download_ipc_lock:
|
|
|
|
# NOTE(kzaitsev):
|
|
# in case there were 2 concurrent threads/processes one might have
|
|
# already downloaded this package. Check before trying to download
|
|
if os.path.isdir(package_directory):
|
|
try:
|
|
return load_utils.load_from_dir(package_directory)
|
|
except pkg_exc.PackageLoadError:
|
|
LOG.error(
|
|
_LE('Unable to load package from cache. Clean-up.'))
|
|
shutil.rmtree(package_directory, ignore_errors=True)
|
|
|
|
# attempt the download itself
|
|
try:
|
|
LOG.debug("Attempting to download package {} {}".format(
|
|
package_def.fully_qualified_name, package_id))
|
|
package_data = self._murano_client_factory().packages.download(
|
|
package_id)
|
|
except muranoclient_exc.HTTPException as e:
|
|
msg = 'Error loading package id {0}: {1}'.format(
|
|
package_id, str(e)
|
|
)
|
|
exc_info = sys.exc_info()
|
|
six.reraise(pkg_exc.PackageLoadError(msg), None, exc_info[2])
|
|
package_file = None
|
|
try:
|
|
with tempfile.NamedTemporaryFile(delete=False) as package_file:
|
|
package_file.write(package_data)
|
|
|
|
with load_utils.load_from_file(
|
|
package_file.name,
|
|
target_dir=package_directory,
|
|
drop_dir=False) as app_package:
|
|
LOG.info(_LI(
|
|
"Successfully downloaded and unpacked package {} {}")
|
|
.format(package_def.fully_qualified_name, package_id))
|
|
self._downloaded.append(app_package)
|
|
|
|
self.try_cleanup_cache(
|
|
os.path.split(package_directory)[0],
|
|
current_id=package_id)
|
|
return app_package
|
|
except IOError:
|
|
msg = 'Unable to extract package data for %s' % package_id
|
|
exc_info = sys.exc_info()
|
|
raise pkg_exc.PackageLoadError(msg), None, exc_info[2]
|
|
finally:
|
|
try:
|
|
if package_file:
|
|
os.remove(package_file.name)
|
|
except OSError:
|
|
pass
|
|
|
|
def try_cleanup_cache(self, package_directory=None, current_id=None):
|
|
if not package_directory:
|
|
return
|
|
|
|
pkg_ids_listed = set()
|
|
try:
|
|
pkg_ids_listed = set(os.listdir(package_directory))
|
|
except OSError:
|
|
# No directory for this package, probably someone
|
|
# already deleted everything. Anyway nothing to delete
|
|
return
|
|
|
|
# if current_id was given: ensure it's not checked for removal
|
|
pkg_ids_listed -= {current_id}
|
|
|
|
for pkg_id in pkg_ids_listed:
|
|
stale_directory = os.path.join(
|
|
package_directory,
|
|
pkg_id)
|
|
if os.path.isdir(package_directory):
|
|
|
|
usage_lock_path = os.path.join(
|
|
self._cache_directory,
|
|
'{}_usage.lock'.format(current_id))
|
|
ipc_lock = m_utils.ExclusiveInterProcessLock(
|
|
path=usage_lock_path, sleep_func=eventlet.sleep)
|
|
|
|
with usage_mem_locks[pkg_id].write_lock(False) as acquired:
|
|
if not acquired:
|
|
continue
|
|
acquired_ipc_lock = ipc_lock.acquire(blocking=False)
|
|
if acquired_ipc_lock:
|
|
shutil.rmtree(stale_directory,
|
|
ignore_errors=True)
|
|
ipc_lock.release()
|
|
|
|
def _get_best_package_match(self, packages):
|
|
public = None
|
|
other = []
|
|
for package in packages:
|
|
if package.owner_id == self.tenant_id:
|
|
return package
|
|
elif package.is_public:
|
|
public = package
|
|
else:
|
|
other.append(package)
|
|
if public is not None:
|
|
return public
|
|
elif other:
|
|
return other[0]
|
|
|
|
def _lock_usage(self, package_definition):
|
|
"""Locks package for usage"""
|
|
|
|
# do not lock anything if we do not persist packages on disk
|
|
if not CONF.packages_opts.enable_packages_cache:
|
|
return
|
|
|
|
# A work around the fact that read_lock only supports `with` syntax.
|
|
mem_lock = _with_to_generator(
|
|
usage_mem_locks[package_definition].read_lock())
|
|
|
|
package_id = package_definition.id
|
|
usage_lock_path = os.path.join(self._cache_directory,
|
|
'{}_usage.lock'.format(package_id))
|
|
ipc_lock = m_utils.SharedInterProcessLock(
|
|
path=usage_lock_path,
|
|
sleep_func=eventlet.sleep
|
|
)
|
|
ipc_lock = _with_to_generator(ipc_lock)
|
|
|
|
next(mem_lock)
|
|
next(ipc_lock)
|
|
self._mem_locks.append(mem_lock)
|
|
self._ipc_locks.append(ipc_lock)
|
|
|
|
def cleanup(self):
|
|
"""Cleans up any lock we had acquired and removes any stale packages"""
|
|
|
|
if not CONF.packages_opts.enable_packages_cache:
|
|
shutil.rmtree(self._cache_directory, ignore_errors=True)
|
|
return
|
|
|
|
for lock in itertools.chain(self._mem_locks, self._ipc_locks):
|
|
try:
|
|
next(lock)
|
|
except StopIteration:
|
|
continue
|
|
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc_val, exc_tb):
|
|
self.cleanup()
|
|
return False
|
|
|
|
|
|
class DirectoryPackageLoader(package_loader.MuranoPackageLoader):
|
|
def __init__(self, base_path, root_loader=None):
|
|
self._base_path = base_path
|
|
self._packages_by_class = {}
|
|
self._packages_by_name = {}
|
|
self._loaded_packages = set()
|
|
self._root_loader = root_loader or self
|
|
self._build_index()
|
|
|
|
def _build_index(self):
|
|
for folder in self.search_package_folders(self._base_path):
|
|
try:
|
|
package = load_utils.load_from_dir(folder)
|
|
dsl_package = murano_package.MuranoPackage(
|
|
self._root_loader, package)
|
|
for class_name in package.classes:
|
|
dsl_package.register_class(
|
|
(lambda pkg, cls:
|
|
lambda: get_class(pkg, cls))(package, class_name),
|
|
class_name
|
|
)
|
|
if dsl_package.name == constants.CORE_LIBRARY:
|
|
system_objects.register(dsl_package)
|
|
self.register_package(dsl_package)
|
|
except pkg_exc.PackageLoadError:
|
|
LOG.info(_LI('Unable to load package from path: {0}').format(
|
|
folder))
|
|
continue
|
|
LOG.info(_LI('Loaded package from path {0}').format(folder))
|
|
|
|
def load_class_package(self, class_name, version_spec):
|
|
packages = self._packages_by_class.get(class_name)
|
|
if not packages:
|
|
raise exceptions.NoPackageForClassFound(class_name)
|
|
version = version_spec.select(six.iterkeys(packages))
|
|
if not version:
|
|
raise exceptions.NoPackageForClassFound(class_name)
|
|
return packages[version]
|
|
|
|
def load_package(self, package_name, version_spec):
|
|
packages = self._packages_by_name.get(package_name)
|
|
if not packages:
|
|
raise exceptions.NoPackageFound(package_name)
|
|
version = version_spec.select(six.iterkeys(packages))
|
|
if not version:
|
|
raise exceptions.NoPackageFound(package_name)
|
|
return packages[version]
|
|
|
|
def register_package(self, package):
|
|
for c in package.classes:
|
|
self._packages_by_class.setdefault(c, {})[
|
|
package.version] = package
|
|
self._packages_by_name.setdefault(package.name, {})[
|
|
package.version] = package
|
|
|
|
@property
|
|
def packages(self):
|
|
for package_versions in six.itervalues(self._packages_by_name):
|
|
for package in six.itervalues(package_versions):
|
|
yield package
|
|
|
|
@staticmethod
|
|
def split_path(path):
|
|
tail = True
|
|
while tail:
|
|
path, tail = os.path.split(path)
|
|
if tail:
|
|
yield path
|
|
|
|
@classmethod
|
|
def search_package_folders(cls, path):
|
|
packages = set()
|
|
for folder, _, files in os.walk(path):
|
|
if 'manifest.yaml' in files:
|
|
found = False
|
|
for part in cls.split_path(folder):
|
|
if part in packages:
|
|
found = True
|
|
break
|
|
if not found:
|
|
packages.add(folder)
|
|
yield folder
|
|
|
|
def cleanup(self):
|
|
"""A stub for possible cleanup"""
|
|
pass
|
|
|
|
|
|
class CombinedPackageLoader(package_loader.MuranoPackageLoader):
|
|
def __init__(self, murano_client_factory, tenant_id, root_loader=None):
|
|
root_loader = root_loader or self
|
|
self.api_loader = ApiPackageLoader(
|
|
murano_client_factory, tenant_id, root_loader)
|
|
self.directory_loaders = []
|
|
|
|
for folder in CONF.engine.load_packages_from:
|
|
if os.path.exists(folder):
|
|
self.directory_loaders.append(DirectoryPackageLoader(
|
|
folder, root_loader))
|
|
|
|
def load_package(self, package_name, version_spec):
|
|
for loader in self.directory_loaders:
|
|
try:
|
|
return loader.load_package(package_name, version_spec)
|
|
except exceptions.NoPackageFound:
|
|
continue
|
|
return self.api_loader.load_package(
|
|
package_name, version_spec)
|
|
|
|
def load_class_package(self, class_name, version_spec):
|
|
for loader in self.directory_loaders:
|
|
try:
|
|
return loader.load_class_package(class_name, version_spec)
|
|
except exceptions.NoPackageForClassFound:
|
|
continue
|
|
return self.api_loader.load_class_package(
|
|
class_name, version_spec)
|
|
|
|
def register_package(self, package):
|
|
self.api_loader.register_package(package)
|
|
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc_val, exc_tb):
|
|
self.cleanup()
|
|
return False
|
|
|
|
def cleanup(self):
|
|
"""Calls cleanup method of all loaders we combine"""
|
|
self.api_loader.cleanup()
|
|
for d_loader in self.directory_loaders:
|
|
d_loader.cleanup()
|
|
|
|
|
|
def get_class(package, name):
|
|
version = package.runtime_version
|
|
loader = yaql_yaml_loader.get_loader(version)
|
|
contents, file_id = package.get_class(name)
|
|
return loader(contents, file_id)
|
|
|
|
|
|
def _with_to_generator(context_obj):
|
|
with context_obj as obj:
|
|
yield obj
|
|
yield
|