openstack/deb-neutron
Code Issues Proposed changes

tests: stop using ml2 plugin full import paths in tests

Browse Source 
Stevedore documentation suggest that full import paths are not supposed
to be user visible. Since unit tests emulate users when configuring
oslo.config, we better off relying on well known plugin aliases than
internal details.

For in-tree that may be not a big deal, but with it we set a bad example
for third parties that may later find their tests broken eg. when we
decide to move code around.

TrivialFix

Change-Id: I7bd036ac3df7e7f4c678356d0a793e7d38599dda
This commit is contained in:
Ihar Hrachyshka
2016-07-25 16:52:05 +02:00
parent 122a971656
commit 2a23527a9a
17 changed files with 24 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
neutron/tests/functional/scheduler/test_l3_agent_scheduler.py
View File

@@ -280,8 +280,7 @@ class L3LeastRoutersSchedulerTestCase(L3SchedulerBaseTest):
class L3AZSchedulerBaseTest(test_db_base_plugin_v2.NeutronDbPluginV2TestCase):
def setUp(self):
core_plugin = 'neutron.plugins.ml2.plugin.Ml2Plugin'
super(L3AZSchedulerBaseTest, self).setUp(plugin=core_plugin)
super(L3AZSchedulerBaseTest, self).setUp(plugin='ml2')
self.l3_plugin = l3_router_plugin.L3RouterPlugin()
self.l3_plugin.router_scheduler = None