openstack/deb-nova
Code Issues Proposed changes

Fix order of arguments in assertEqual

Browse Source 
Some tests used incorrect order assertEqual(observed, expected).

The correct order expected by testtools is
assertEqual(expected, observed).

Partial-Bug: #1259292
Change-Id: I30e7c4346844ec0eba50c50ca327ca1966600e7d
This commit is contained in:
PranaliDeore
2015-08-31 00:15:47 -07:00
parent e349663cf2
commit 16db827eaa
9 changed files with 114 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/tests/unit/test_cinder.py
View File

@@ -71,7 +71,7 @@ class BaseCinderTestCase(object):
def test_cinder_api_cacert_file(self):
cacert = "/etc/ssl/certs/ca-certificates.crt"
self.flags(cafile=cacert, group='cinder')
self.assertEqual(self.create_client().client.session.verify, cacert)
self.assertEqual(cacert, self.create_client().client.session.verify)
class CinderTestCase(BaseCinderTestCase, test.NoDBTestCase):
@@ -129,7 +129,7 @@ class CinderTestCase(BaseCinderTestCase, test.NoDBTestCase):
self.assertThat(m.last_request.path,
matchers.EndsWith('/volumes/5678'))
self.assertIn('volume_image_metadata', volume)
self.assertEqual(volume['volume_image_metadata'], _image_metadata)
self.assertEqual(_image_metadata, volume['volume_image_metadata'])
class CinderV2TestCase(BaseCinderTestCase, test.NoDBTestCase):