pep8 fixes and further round of refactoring

nova/virt/connection.py

@@ -25,7 +25,7 @@ import sys
 from nova import flags
 from nova.virt import fake
 from nova.virt import libvirt_conn
-from nova.virt import xenapi
+from nova.virt import xenapi_conn
 
 
 FLAGS = flags.FLAGS
@@ -61,7 +61,7 @@ def get_connection(read_only=False):
     elif t == 'libvirt':
         conn = libvirt_conn.get_connection(read_only)
     elif t == 'xenapi':
-        conn = xenapi.get_connection(read_only)
+        conn = xenapi_conn.get_connection(read_only)
     else:
         raise Exception('Unknown connection type "%s"' % t)
 

nova/virt/xenapi/novadeps.py

@@ -18,6 +18,7 @@ from nova import db
 from nova import flags
 from nova import process
 from nova import utils
+from nova import context
 
 from nova.compute import power_state
 from nova.auth.manager import AuthManager
@@ -64,7 +65,9 @@ class Instance(object):
 
     @classmethod
     def get_network(self, instance):
-        return db.project_get_network(None, instance.project_id)
+        # TODO: is ge_admin_context the right context to retrieve?
+        return db.project_get_network(context.get_admin_context(),
+                                      instance.project_id)
 
     @classmethod
     def get_mac(self, instance):

nova/virt/xenapi/vm_utils.py

@@ -33,7 +33,7 @@ from novadeps import User
 class VMHelper():
     def __init__(self, session):
         return
-    
+
     @classmethod
     @defer.inlineCallbacks
     def create_vm(self, session, instance, kernel, ramdisk):

nova/virt/xenapi_conn.py

@@ -52,13 +52,12 @@ import xmlrpclib
 
 from twisted.internet import defer
 from twisted.internet import reactor
-#from twisted.internet import task
 
 from nova import flags
 from nova import utils
 
-from xapi.vmops import VMOps
-from xapi.volumeops import VolumeOps
+from xenapi.vmops import VMOps
+from xenapi.volumeops import VolumeOps
 
 XenAPI = None