openstack/deb-nova
Code Issues Proposed changes

Get test_openAuth_can_refuse_None_uri to cleanup after itself

Browse Source 
test_openAuth_can_refuse_None_uri sets the global
libvirt.allow_default_uri_connection to False but it leaves
it in this state which could cause test_tpool_execute_calls_libvirt
to fail if it ran immediately afterwards. This patch adds a cleanup
so _reset is called at the end of the test and not just if
another test in the same class is run after it.

Change-Id: I9762fcb81b2318beeb056c67bd9172056e1449ab
Closes-Bug: 1258553
This commit is contained in:
Chris Yeoh
2013-12-08 23:57:39 +10:30
parent 16beb012ec
commit f95e0858ad
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
nova/tests/virt/libvirt/test_fakelibvirt.py
View File

@@ -87,6 +87,7 @@ class FakeLibvirtTests(test.NoDBTestCase):
def test_openAuth_can_refuse_None_uri(self): def test_openAuth_can_refuse_None_uri(self):
conn_method = self.get_openAuth_curry_func() conn_method = self.get_openAuth_curry_func()
libvirt.allow_default_uri_connection = False libvirt.allow_default_uri_connection = False
self.addCleanup(libvirt._reset)
self.assertRaises(ValueError, conn_method, None) self.assertRaises(ValueError, conn_method, None)
def test_openAuth_refuses_invalid_URI(self): def test_openAuth_refuses_invalid_URI(self):