5ac81f47a4
There was an exceptionally large amount of rote use of _get_regexes throughout the samples tests, which doesn't provide any additional explicitness in what's happening, and only couples the tests to the base class in less useful ways. Instead, when we call _verify_response, always also use the base vanilla regexes for matching tests. We also needed to add a few more variables to the list which always need to be reset before testing against the static samples, because uuids are often generated on the fly for the tests. Lastly, test_keypairs needed some test specific surgery. It is so highly normalized (with private test methods that take **kwargs) at this point that it's not really clear that it's testing useful things any more. This really needs denormalization. Change-Id: I165b0f3aa2132373cb59982a5a5ded37b4fa1b52
230 lines
9.1 KiB
Python
230 lines
9.1 KiB
Python
# Copyright 2012 Nebula, Inc.
|
|
# Copyright 2013 IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import uuid
|
|
|
|
from oslo_config import cfg
|
|
|
|
from nova.objects import keypair as keypair_obj
|
|
from nova.tests.functional.api_sample_tests import api_sample_base
|
|
from nova.tests.unit import fake_crypto
|
|
|
|
CONF = cfg.CONF
|
|
CONF.import_opt('osapi_compute_extension',
|
|
'nova.api.openstack.compute.legacy_v2.extensions')
|
|
|
|
|
|
class KeyPairsSampleJsonTest(api_sample_base.ApiSampleTestBaseV21):
|
|
microversion = None
|
|
sample_dir = "keypairs"
|
|
expected_delete_status_code = 202
|
|
expected_post_status_code = 200
|
|
|
|
def _get_flags(self):
|
|
f = super(KeyPairsSampleJsonTest, self)._get_flags()
|
|
f['osapi_compute_extension'] = CONF.osapi_compute_extension[:]
|
|
f['osapi_compute_extension'].append(
|
|
'nova.api.openstack.compute.contrib.keypairs.Keypairs')
|
|
return f
|
|
|
|
# TODO(sdague): this is only needed because we randomly choose the
|
|
# uuid each time.
|
|
def generalize_subs(self, subs, vanilla_regexes):
|
|
subs['keypair_name'] = 'keypair-[0-9a-f-]+'
|
|
return subs
|
|
|
|
def test_keypairs_post(self):
|
|
return self._check_keypairs_post()
|
|
|
|
def _check_keypairs_post(self, **kwargs):
|
|
"""Get api sample of key pairs post request."""
|
|
key_name = 'keypair-' + str(uuid.uuid4())
|
|
subs = dict(keypair_name=key_name, **kwargs)
|
|
response = self._do_post('os-keypairs', 'keypairs-post-req', subs,
|
|
api_version=self.microversion)
|
|
subs = {'keypair_name': key_name}
|
|
|
|
self._verify_response('keypairs-post-resp', subs, response,
|
|
self.expected_post_status_code)
|
|
# NOTE(maurosr): return the key_name is necessary cause the
|
|
# verification returns the label of the last compared information in
|
|
# the response, not necessarily the key name.
|
|
return key_name
|
|
|
|
def test_keypairs_import_key_post(self):
|
|
public_key = fake_crypto.get_ssh_public_key()
|
|
self._check_keypairs_import_key_post(public_key)
|
|
|
|
def _check_keypairs_import_key_post(self, public_key, **kwargs):
|
|
# Get api sample of key pairs post to import user's key.
|
|
key_name = 'keypair-' + str(uuid.uuid4())
|
|
subs = {
|
|
'keypair_name': key_name,
|
|
}
|
|
params = subs.copy()
|
|
params['public_key'] = public_key
|
|
params.update(**kwargs)
|
|
response = self._do_post('os-keypairs', 'keypairs-import-post-req',
|
|
params, api_version=self.microversion)
|
|
self._verify_response('keypairs-import-post-resp', subs, response,
|
|
self.expected_post_status_code)
|
|
|
|
def test_keypairs_list(self):
|
|
# Get api sample of key pairs list request.
|
|
key_name = self.test_keypairs_post()
|
|
response = self._do_get('os-keypairs',
|
|
api_version=self.microversion)
|
|
subs = {'keypair_name': key_name}
|
|
self._verify_response('keypairs-list-resp', subs, response, 200)
|
|
|
|
def test_keypairs_get(self):
|
|
# Get api sample of key pairs get request.
|
|
key_name = self.test_keypairs_post()
|
|
response = self._do_get('os-keypairs/%s' % key_name,
|
|
api_version=self.microversion)
|
|
subs = {'keypair_name': key_name}
|
|
self._verify_response('keypairs-get-resp', subs, response, 200)
|
|
|
|
def test_keypairs_delete(self):
|
|
# Get api sample of key pairs delete request.
|
|
key_name = self.test_keypairs_post()
|
|
response = self._do_delete('os-keypairs/%s' % key_name,
|
|
api_version=self.microversion)
|
|
self.assertEqual(self.expected_delete_status_code,
|
|
response.status_code)
|
|
|
|
|
|
class KeyPairsV22SampleJsonTest(KeyPairsSampleJsonTest):
|
|
microversion = '2.2'
|
|
expected_post_status_code = 201
|
|
expected_delete_status_code = 204
|
|
# NOTE(gmann): microversion tests do not need to run for v2 API
|
|
# so defining scenarios only for v2.2 which will run the original tests
|
|
# by appending '(v2_2)' in test_id.
|
|
scenarios = [('v2_2', {'api_major_version': 'v2.1'})]
|
|
|
|
def test_keypairs_post(self):
|
|
# NOTE(claudiub): overrides the method with the same name in
|
|
# KeypairsSampleJsonTest, as it is used by other tests.
|
|
return self._check_keypairs_post(
|
|
keypair_type=keypair_obj.KEYPAIR_TYPE_SSH)
|
|
|
|
def test_keypairs_post_x509(self):
|
|
return self._check_keypairs_post(
|
|
keypair_type=keypair_obj.KEYPAIR_TYPE_X509)
|
|
|
|
def test_keypairs_post_invalid(self):
|
|
key_name = 'keypair-' + str(uuid.uuid4())
|
|
subs = dict(keypair_name=key_name, keypair_type='fakey_type')
|
|
response = self._do_post('os-keypairs', 'keypairs-post-req', subs,
|
|
api_version=self.microversion)
|
|
|
|
self.assertEqual(400, response.status_code)
|
|
|
|
def test_keypairs_import_key_post(self):
|
|
# NOTE(claudiub): overrides the method with the same name in
|
|
# KeypairsSampleJsonTest, since the API sample expects a keypair_type.
|
|
public_key = fake_crypto.get_ssh_public_key()
|
|
self._check_keypairs_import_key_post(
|
|
public_key, keypair_type=keypair_obj.KEYPAIR_TYPE_SSH)
|
|
|
|
def test_keypairs_import_key_post_x509(self):
|
|
public_key = fake_crypto.get_x509_cert_and_fingerprint()[0]
|
|
public_key = public_key.replace('\n', '\\n')
|
|
self._check_keypairs_import_key_post(
|
|
public_key, keypair_type=keypair_obj.KEYPAIR_TYPE_X509)
|
|
|
|
def _check_keypairs_import_key_post_invalid(self, keypair_type):
|
|
key_name = 'keypair-' + str(uuid.uuid4())
|
|
subs = {
|
|
'keypair_name': key_name,
|
|
'keypair_type': keypair_type,
|
|
'public_key': fake_crypto.get_ssh_public_key()
|
|
}
|
|
response = self._do_post('os-keypairs', 'keypairs-import-post-req',
|
|
subs, api_version=self.microversion)
|
|
|
|
self.assertEqual(400, response.status_code)
|
|
|
|
def test_keypairs_import_key_post_invalid_type(self):
|
|
self._check_keypairs_import_key_post_invalid(
|
|
keypair_type='fakey_type')
|
|
|
|
def test_keypairs_import_key_post_invalid_combination(self):
|
|
self._check_keypairs_import_key_post_invalid(
|
|
keypair_type=keypair_obj.KEYPAIR_TYPE_X509)
|
|
|
|
|
|
class KeyPairsV210SampleJsonTest(KeyPairsSampleJsonTest):
|
|
ADMIN_API = True
|
|
microversion = '2.10'
|
|
expected_post_status_code = 201
|
|
expected_delete_status_code = 204
|
|
scenarios = [('v2_10', {'api_major_version': 'v2.1'})]
|
|
|
|
def test_keypair_create_for_user(self):
|
|
subs = {
|
|
'keypair_type': keypair_obj.KEYPAIR_TYPE_SSH,
|
|
'public_key': fake_crypto.get_ssh_public_key(),
|
|
'user_id': "fake"
|
|
}
|
|
self._check_keypairs_post(**subs)
|
|
|
|
def test_keypairs_post(self):
|
|
return self._check_keypairs_post(
|
|
keypair_type=keypair_obj.KEYPAIR_TYPE_SSH,
|
|
user_id="admin")
|
|
|
|
def test_keypairs_import_key_post(self):
|
|
# NOTE(claudiub): overrides the method with the same name in
|
|
# KeypairsSampleJsonTest, since the API sample expects a keypair_type.
|
|
public_key = fake_crypto.get_ssh_public_key()
|
|
self._check_keypairs_import_key_post(
|
|
public_key, keypair_type=keypair_obj.KEYPAIR_TYPE_SSH,
|
|
user_id="fake")
|
|
|
|
def test_keypairs_delete_for_user(self):
|
|
# Delete a keypair on behalf of a user
|
|
subs = {
|
|
'keypair_type': keypair_obj.KEYPAIR_TYPE_SSH,
|
|
'public_key': fake_crypto.get_ssh_public_key(),
|
|
'user_id': "fake"
|
|
}
|
|
key_name = self._check_keypairs_post(**subs)
|
|
response = self._do_delete('os-keypairs/%s?user_id=fake' % key_name,
|
|
api_version=self.microversion)
|
|
self.assertEqual(self.expected_delete_status_code,
|
|
response.status_code)
|
|
|
|
|
|
class KeyPairsV210SampleJsonTestNotAdmin(KeyPairsV210SampleJsonTest):
|
|
ADMIN_API = False
|
|
|
|
def test_keypairs_post(self):
|
|
return self._check_keypairs_post(
|
|
keypair_type=keypair_obj.KEYPAIR_TYPE_SSH,
|
|
user_id="fake")
|
|
|
|
def test_keypairs_post_for_other_user(self):
|
|
key_name = 'keypair-' + str(uuid.uuid4())
|
|
subs = dict(keypair_name=key_name,
|
|
keypair_type=keypair_obj.KEYPAIR_TYPE_SSH,
|
|
user_id='fake1')
|
|
response = self._do_post('os-keypairs', 'keypairs-post-req', subs,
|
|
api_version=self.microversion,
|
|
)
|
|
|
|
self.assertEqual(403, response.status_code)
|