openstack/deb-novnc
Code Issues Proposed changes

Fix listen_port check.

Browse Source 
Interestingly, the bug depends on compiler behavior. If local
variables are automatically initialized to 0, then this always caused
the program to error out indicating a failure to parse the listen
port. Otherwise, the test was a no-op (except the rare case where the
memory happened to be zero anyways).

Thanks to Eugen Melnikoff for finding this.
This commit is contained in:
Joel Martin 2010-07-17 12:13:54 -05:00
parent db6ae6c6a0
commit 17037bee9b
1 changed files with 2 additions and 2 deletions

4
utils/wsproxy.c

@ -245,7 +245,7 @@ void proxy_handler(ws_ctx_t *ws_ctx) {
int main(int argc, char *argv[])
{
int listen_port, fd, c, option_index = 0;
int fd, c, option_index = 0;
static int ssl_only = 0, foreground = 0;
char *found;
static struct option long_options[] = {
@ -309,7 +309,7 @@ int main(int argc, char *argv[])
settings.listen_port = strtol(argv[optind], NULL, 10);
}
optind++;
if (listen_port == 0) {
if (settings.listen_port == 0) {
usage("Could not parse listen_port\n");
}