openstack/deb-python-autobahn
Code Issues Proposed changes

Merge pull request #613 from meejah/tracebacks-from-onmessage

Browse Source 
Properly log tracebacks
This commit is contained in:
Tobias Oberstein
2016-03-15 12:04:21 +01:00
parent a28fbe6aec 295034307d
commit a9c3451a1a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
autobahn/wamp/websocket.py
View File

@@ -60,7 +60,7 @@ class WampWebSocketProtocol(object):
self._session = self.factory._factory() self._session = self.factory._factory()
self._session.onOpen(self) self._session.onOpen(self)
except Exception as e: except Exception as e:
self.log.critical(traceback.format_exc()) self.log.critical("{tb}", tb=traceback.format_exc())
reason = u'WAMP Internal Error ({0})'.format(e) reason = u'WAMP Internal Error ({0})'.format(e)
self._bailout(protocol.WebSocketProtocol.CLOSE_STATUS_CODE_INTERNAL_ERROR, reason=reason) self._bailout(protocol.WebSocketProtocol.CLOSE_STATUS_CODE_INTERNAL_ERROR, reason=reason)
@@ -90,12 +90,12 @@ class WampWebSocketProtocol(object):
self._session.onMessage(msg) self._session.onMessage(msg)
except ProtocolError as e: except ProtocolError as e:
self.log.critical(traceback.format_exc()) self.log.critical("{tb}", tb=traceback.format_exc())
reason = u'WAMP Protocol Error ({0})'.format(e) reason = u'WAMP Protocol Error ({0})'.format(e)
self._bailout(protocol.WebSocketProtocol.CLOSE_STATUS_CODE_PROTOCOL_ERROR, reason=reason) self._bailout(protocol.WebSocketProtocol.CLOSE_STATUS_CODE_PROTOCOL_ERROR, reason=reason)
except Exception as e: except Exception as e:
self.log.critical(traceback.format_exc()) self.log.critical("{tb}", tb=traceback.format_exc())
reason = u'WAMP Internal Error ({0})'.format(e) reason = u'WAMP Internal Error ({0})'.format(e)
self._bailout(protocol.WebSocketProtocol.CLOSE_STATUS_CODE_INTERNAL_ERROR, reason=reason) self._bailout(protocol.WebSocketProtocol.CLOSE_STATUS_CODE_INTERNAL_ERROR, reason=reason)