Fixing test for PYTHON-235

tests/integration/standard/test_query.py

@@ -27,7 +27,7 @@ from cassandra.query import (PreparedStatement, BoundStatement, SimpleStatement,
 from cassandra.cluster import Cluster
 from cassandra.policies import HostDistance
 
-from tests.integration import use_singledc, PROTOCOL_VERSION
+from tests.integration import use_singledc, PROTOCOL_VERSION, get_server_versions
 
 
 def setup_module():
@@ -89,42 +89,45 @@ class QueryTests(unittest.TestCase):
 
         cluster.shutdown()
 
-    def test_trace_client_ip(self):
+    def test_client_ip_in_trace(self):
         """
-+       Test to validate that client trace contains client ip information.
+        Test to validate that client trace contains client ip information.
-+
-+       creates a simple query and ensures that the client trace information is present. This will
-        only be the case if the CQL version is 4 or greater./
 
-+
+        creates a simple query and ensures that the client trace information is present. This will
-+       @since 3.0
+        only be the case if the c* version is 3.0 or greater
-+       @jira_ticket PYTHON-235
+
-+       @expected_result client address should be present in CQL > 4, otherwise should be none.
+
-+
+        @since 3.0
-+       @test_category trace
+        @jira_ticket PYTHON-235
+        @expected_result client address should be present in C* > 3, otherwise should be none.
+
+        @test_category tracing
 +       """
+        #The current version on the trunk doesn't have the version set to 3.0 yet.
+        #For now we will use the protocol version. Once they update the version on C* trunk
+        #we can use the C*. See below
+        #self._cass_version, self._cql_version = get_server_versions()
+        #if self._cass_version < (3, 0):
+        #   raise unittest.SkipTest("Client IP was not present in trace until C* 3.0")
         if PROTOCOL_VERSION < 4:
-            raise unittest.SkipTest(
+             raise unittest.SkipTest(
-                "Protocol 4+ is required for client ip tracing, currently testing against %r"
+                 "Protocol 4+ is required for client ip tracing, currently testing against %r"
-                % (PROTOCOL_VERSION,))
+                 % (PROTOCOL_VERSION,))
+
         cluster = Cluster(protocol_version=PROTOCOL_VERSION)
         session = cluster.connect()
 
         query = "SELECT * FROM system.local"
         statement = SimpleStatement(query)
-        session.execute(statement, trace=True)
+        response_future = session.execute_async(statement, trace=True)
-
+        response_future.result(10.0)
+        current_host = response_future._current_host.address
         # Fetch the client_ip from the trace.
-        client_ip=statement.trace.client
+        trace = response_future.get_query_trace(2.0)
-        # Ensure that ip is set for CQL >4
+        client_ip = trace.client
-        self.assertIsNotNone(client_ip,"Client IP was not set in trace with CQL >=4.0")
+        # Ensure that ip is set for c* >3
-        # TODO we might want validate that client_ip actually matches our local ip rather than just validate that it
+        self.assertIsNotNone(client_ip,"Client IP was not set in trace with C* > 3.0")
-        # is a valid ip.
+        self.assertEqual(client_ip,current_host,"Client IP from trace did not match the expected value")
-        try:
-            socket.inet_aton(client_ip)
-        except socket.error:
-            self.fail("Client IP retrieved from trace was not valid :{0}".format(client_ip))
-
         cluster.shutdown()