openstack/deb-python-ceilometerclient
Code Issues Proposed changes

Restructuring a comment in Python-Ceilometerclient

Browse Source 
The comment describes the handling of HTTPNotFound exception about
alarm, but it is ambiguous, this change make it more clear.

Closes-Bug:#1523866
Change-Id: Id7be71dcda6693875222435e10cba929e7c81e56
This commit is contained in:
Sanjana Pai
2015-12-09 12:03:26 +05:30
committed by sanjana
parent 9eb552d023
commit 2af229206d
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ceilometerclient/v2/alarms.py
View File

@@ -89,11 +89,10 @@ class AlarmManager(base.Manager):
return None return None
except exc.HTTPNotFound: except exc.HTTPNotFound:
# When we try to get deleted alarm HTTPNotFound occurs # When we try to get a deleted alarm, or
# or when alarm doesn't exists this exception don't must # when an alarm doesn't exist, HTTPNotFound exception occurs.
# go deeper because cleanUp() (method which remove all # Since scenario tests at the time of cleanUp() will not know
# created things like instance, alarm, etc.) at scenario # how to handle it, we only return None.
# tests doesn't know how to process it
return None return None
@classmethod @classmethod