openstack
/
deb-python-cinderclient
Code Issues Proposed changes

Fix some flake8 violations 

1. Wrong use of 'noqa'. "# flake8: noqa" option disables all checks
for the whole file.
2. Remove exclusion of 'tools' and '*openstack/common*' in flake8 and
fix the violations.

Change-Id: I153e992ffd6a80e70a99d7066c503c34326c93ab
Closes-bug: #1540254
This commit is contained in:
Chaozhe.Chen 2016-02-09 17:00:30 +08:00
parent bdeab3af0e
commit 9e60e4a592
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinderclient/openstack/common/apiclient/fake_client.py
View File

@ -81,7 +81,7 @@ class FakeHTTPClient(client.HTTPClient):
def __init__(self, *args, **kwargs):
self.callstack = []
self.fixtures = kwargs.pop("fixtures", None) or {}
if not args and not "auth_plugin" in kwargs:
if not args and "auth_plugin" not in kwargs:
args = (None, )
super(FakeHTTPClient, self).__init__(*args, **kwargs)

4
tools/install_venv.py
View File

@ -22,7 +22,7 @@ import ConfigParser
import os
import sys
import install_venv_common as install_venv # flake8: noqa
import install_venv_common as install_venv
def print_help(project, venv, root):
@ -42,7 +42,7 @@ def print_help(project, venv, root):
$ %(root)s/tools/with_venv.sh <your command>
"""
print help % dict(project=project, venv=venv, root=root)
print (help % dict(project=project, venv=venv, root=root))
def main(argv):

2
tox.ini
View File

@ -44,4 +44,4 @@ passenv = OS_*
[flake8]
show-source = True
ignore = F811,F821,H306,H404,H405,E122,E123,E128,E251
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build