From 4b894d17494e8c226e1105bc0a46859562c2bc35 Mon Sep 17 00:00:00 2001 From: Michael Gummelt Date: Fri, 26 Jun 2015 13:40:07 -0700 Subject: [PATCH] group rollbar messages around just the exception title --- cli/dcoscli/analytics.py | 9 ++++++++- cli/tests/data/analytics/dcos_reporting.toml | 2 +- cli/tests/integrations/test_analytics.py | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/cli/dcoscli/analytics.py b/cli/dcoscli/analytics.py index fe49a43..cedfdc7 100644 --- a/cli/dcoscli/analytics.py +++ b/cli/dcoscli/analytics.py @@ -211,8 +211,15 @@ def _rollbar_track_err(conf, err, exit_code): props = _base_properties(conf) props['exit_code'] = exit_code + lines = err.split('\n') + if len(lines) >= 2: + title = lines[-2] + else: + title = err + props['stderr'] = err + try: - rollbar.report_message(err, 'error', extra_data=props) + rollbar.report_message(title, 'error', extra_data=props) except Exception as e: logger.exception(e) diff --git a/cli/tests/data/analytics/dcos_reporting.toml b/cli/tests/data/analytics/dcos_reporting.toml index 590a344..637ea68 100644 --- a/cli/tests/data/analytics/dcos_reporting.toml +++ b/cli/tests/data/analytics/dcos_reporting.toml @@ -1,3 +1,3 @@ [core] -reporting = true email = "test@mail.com" +reporting = true diff --git a/cli/tests/integrations/test_analytics.py b/cli/tests/integrations/test_analytics.py index ac7665d..3281140 100644 --- a/cli/tests/integrations/test_analytics.py +++ b/cli/tests/integrations/test_analytics.py @@ -93,6 +93,7 @@ def test_exc(): # rollbar props = _base_properties() props['exit_code'] = 1 + props['stderr'] = 'Traceback' rollbar.report_message.assert_called_with('Traceback', 'error', extra_data=props)