Currently we have all our elements and library files in a top-level directory and install them into <root>/share/diskimage-builder/[elements|lib] (where root is either / or the root of a virtualenv). The problem with this is that editable/development installs (pip -e) do *not* install data_files. Thus we have no canonical location to look for elements -- leading to the various odd things we do such as a whole bunch of guessing at the top of disk-image-create and having a special test-loader in tests/test_elements.py so we can run python unit tests on those elements that have it. data_files is really the wrong thing to use for what are essentially assets of the program. data_files install works well for things like config-files, init.d files or dropping documentation files. By moving the elements under the diskimage_builder package, we always know where they are relative to where we import from. In fact, pkg_resources has an api for this which we wrap in the new diskimage_builder/paths.py helper [1]. We use this helper to find the correct path in the couple of places we need to find the base-elements dir, and for the paths to import the library shell functions. Elements such as svc-map and pkg-map include python unit-tests, which we do not need tests/test_elements.py to special-case load any more. They just get found automatically by the normal subunit loader. I have a follow-on change (I69ca3d26fede0506a6353c077c69f735c8d84d28) to move disk-image-create to a regular python entry-point. Unfortunately, this has to move to work with setuptools. You'd think a symlink under diskimage_builder/[elements|lib] would work, but it doesn't. [1] this API handles stuff like getting files out of .zip archive modules, which we don't do. Essentially for us it's returning __file__. Change-Id: I5e3e3c97f385b1a4ff2031a161a55b231895df5b
		
			
				
	
	
		
			49 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			49 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
#!/bin/bash
 | 
						|
#
 | 
						|
# Copyright 2014 Hewlett-Packard Development Company, L.P.
 | 
						|
# All Rights Reserved.
 | 
						|
#
 | 
						|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
 | 
						|
# not use this file except in compliance with the License. You may obtain
 | 
						|
# a copy of the License at
 | 
						|
#
 | 
						|
#     http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
#
 | 
						|
# Unless required by applicable law or agreed to in writing, software
 | 
						|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 | 
						|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 | 
						|
# License for the specific language governing permissions and limitations
 | 
						|
# under the License.
 | 
						|
 | 
						|
# dib-lint: disable=safe_sudo
 | 
						|
 | 
						|
if [ ${DIB_DEBUG_TRACE:-1} -gt 0 ]; then
 | 
						|
    set -x
 | 
						|
fi
 | 
						|
set -eu
 | 
						|
set -o pipefail
 | 
						|
 | 
						|
[ -n "$TARGET_ROOT" ]
 | 
						|
 | 
						|
source $_LIB/img-functions
 | 
						|
 | 
						|
if [ -d $TARGET_ROOT/boot/extlinux ] ; then
 | 
						|
    CONF=$TARGET_ROOT/boot/extlinux/extlinux.conf
 | 
						|
elif [ -d $TARGET_ROOT/boot/syslinux ] ; then
 | 
						|
    CONF=$TARGET_ROOT/boot/syslinux/syslinux.cfg
 | 
						|
else
 | 
						|
    exit 0
 | 
						|
fi
 | 
						|
 | 
						|
# Dig up the initrd and kernel to use.
 | 
						|
select_boot_kernel_initrd $TARGET_ROOT
 | 
						|
 | 
						|
sudo sh -c "cat > $CONF <<_EOF_
 | 
						|
DEFAULT linux
 | 
						|
 | 
						|
LABEL linux
 | 
						|
    KERNEL /boot/$KERNEL
 | 
						|
    APPEND ro root=LABEL=${DIB_ROOT_LABEL} console=tty0 console=ttyS0,115200 nofb nomodeset vga=normal
 | 
						|
    INITRD /boot/$RAMDISK
 | 
						|
_EOF_"
 |