openstack/deb-python-django-formtools
Code Issues Proposed changes

Replaced django.shortcuts.render_to_response() with render().

Browse Source
This commit is contained in:
Tim Graham
2016-05-28 10:40:24 -04:00
parent 70df5a2dbf
commit 46b6839fb0
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
formtools/preview.py
View File

@@ -2,8 +2,7 @@
Formtools Preview application. Formtools Preview application.
""" """
from django.http import Http404 from django.http import Http404
from django.shortcuts import render_to_response from django.shortcuts import render
from django.template.context import RequestContext
from django.utils.crypto import constant_time_compare from django.utils.crypto import constant_time_compare
from .utils import form_hmac from .utils import form_hmac
@@ -53,9 +52,7 @@ class FormPreview(object):
"Displays the form" "Displays the form"
f = self.form(auto_id=self.get_auto_id(), f = self.form(auto_id=self.get_auto_id(),
initial=self.get_initial(request)) initial=self.get_initial(request))
return render_to_response(self.form_template, return render(request, self.form_template, self.get_context(request, f))
self.get_context(request, f),
context_instance=RequestContext(request))
def preview_post(self, request): def preview_post(self, request):
""" """
@@ -68,11 +65,9 @@ class FormPreview(object):
self.process_preview(request, f, context) self.process_preview(request, f, context)
context['hash_field'] = self.unused_name('hash') context['hash_field'] = self.unused_name('hash')
context['hash_value'] = self.security_hash(request, f) context['hash_value'] = self.security_hash(request, f)
return render_to_response(self.preview_template, context, return render(request, self.preview_template, context)
context_instance=RequestContext(request))
else: else:
return render_to_response(self.form_template, context, return render(request, self.form_template, context)
context_instance=RequestContext(request))
def _check_security_hash(self, token, request, form): def _check_security_hash(self, token, request, form):
expected = self.security_hash(request, form) expected = self.security_hash(request, form)
@@ -90,9 +85,7 @@ class FormPreview(object):
return self.failed_hash(request) # Security hash failed. return self.failed_hash(request) # Security hash failed.
return self.done(request, form.cleaned_data) return self.done(request, form.cleaned_data)
else: else:
return render_to_response(self.form_template, return render(request, self.form_template, self.get_context(request, form))
self.get_context(request, form),
context_instance=RequestContext(request))
# METHODS SUBCLASSES MIGHT OVERRIDE IF APPROPRIATE ######################## # METHODS SUBCLASSES MIGHT OVERRIDE IF APPROPRIATE ########################