openstack/deb-python-eventlet
Code Issues Proposed changes

better comments

Browse Source
This commit is contained in:
Denis Bilenko
2008-10-10 17:26:38 +07:00
parent add7f61d59
commit 865156d82b
1 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
eventlet/hubs/twistedreactor.py
View File

@@ -92,25 +92,19 @@ class Hub:
Hub.state = 3 Hub.state = 3
raise raise
# if we have twisted's signal handlers installed and mainLoop has just exited, # if twisted's signal handlers are installed and mainLoop has just exited,
# we must report the error to the user's greenlet. # we must report the error to the user's greenlet.
# QQQ actually we raise this error in all the user's greenlets, to let them # QQQ actually we must raise this error in all the user's greenlets, to let them
# clean properly. never executing them again is cruel (unless they're daemons) # clean up properly. never executing them again is cruel (unless they're daemons)
raise AssertionError("reactor was stopped") raise AssertionError("reactor was stopped")
def mainLoop(self, reactor): def mainLoop(self, reactor):
Hub.state = 2 Hub.state = 2
# the same as reactor's mainLoop, but without try/except(all) catcher # Unlike reactor's mainLoop, this function does not catch exceptions.
# since this greenlet's parent is the main greenlet, an exception will be # Anything raised goes into the main greenlet (because it is always the
# delegated there. # parent of this one)
# for example. when exception is raised in a signal handlers, it should go
# into the main greenlet.
# (QQQ when there're no references to a greenlet, it should be killed
# with GreenletExit. is it possible for this greenlet to be killed under
# such circumstances?)
while reactor.running: while reactor.running:
# Advance simulation time in delayed event # Advance simulation time in delayed event processors.
# processors.
reactor.runUntilCurrent() reactor.runUntilCurrent()
t2 = reactor.timeout() t2 = reactor.timeout()
t = reactor.running and t2 t = reactor.running and t2