openstack/deb-python-eventlet
Code Issues Proposed changes

When a wsgi application gives a unicode object to the server, which the spec says causes undefined behavior, write a 500 error to the browser instead of just hanging forever.

Browse Source
This commit is contained in:
donovan
2009-01-05 18:47:00 -08:00
parent eb0641b1ee
commit 95e93f0660
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
eventlet/wsgi.py
View File

@@ -181,7 +181,10 @@ class HttpProtocol(BaseHTTPServer.BaseHTTPRequestHandler):
towrite.append(data) towrite.append(data)
joined = ''.join(towrite) joined = ''.join(towrite)
length[0] = length[0] + len(joined) length[0] = length[0] + len(joined)
_write(joined) try:
_write(joined)
except UnicodeEncodeError:
_write("HTTP/1.0 500 Internal Server Error\r\nConnection: close\r\nContent-type: text/plain\r\nContent-length: 98\r\n\r\nInternal Server Error: wsgi application passed a unicode object to the server instead of a string.")
def start_response(status, response_headers, exc_info=None): def start_response(status, response_headers, exc_info=None):
status_code[0] = status.split()[0] status_code[0] = status.split()[0]