From 9d05c68fa209d73ef164909f8c8173d3e67deafb Mon Sep 17 00:00:00 2001 From: Sergey Shepelev Date: Fri, 5 Sep 2014 02:49:43 +0400 Subject: [PATCH] green.socket: create_connection: UnboundLocalError on Python3 Fixes https://github.com/eventlet/eventlet/issues/123 --- eventlet/green/socket.py | 3 ++- tests/socket_test.py | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 tests/socket_test.py diff --git a/eventlet/green/socket.py b/eventlet/green/socket.py index 42ad638..2ec9d1b 100644 --- a/eventlet/green/socket.py +++ b/eventlet/green/socket.py @@ -53,7 +53,8 @@ def create_connection(address, sock.connect(sa) return sock - except error as msg: + except error as e: + msg = e if sock is not None: sock.close() diff --git a/tests/socket_test.py b/tests/socket_test.py new file mode 100644 index 0000000..60881f7 --- /dev/null +++ b/tests/socket_test.py @@ -0,0 +1,8 @@ +from eventlet.green import socket + + +def test_create_connection_error(): + try: + socket.create_connection(('192.0.2.1', 80), timeout=0.1) + except (IOError, OSError): + pass