openstack/deb-python-eventlet
Code Issues Proposed changes

Stop skipping a test unnecessarily

Browse Source
This commit is contained in:
Jakub Stasiak
2015-02-11 23:03:52 +01:00
parent 5ec3a3cba8
commit b4d385aec9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/subprocess_test.py
View File

@@ -1,7 +1,6 @@
import eventlet import eventlet
from eventlet.green import subprocess from eventlet.green import subprocess
import eventlet.patcher import eventlet.patcher
from nose.plugins.skip import SkipTest
import sys import sys
import time import time
original_subprocess = eventlet.patcher.original('subprocess') original_subprocess = eventlet.patcher.original('subprocess')
@@ -29,14 +28,15 @@ def test_subprocess_wait():
def test_communicate_with_poll(): def test_communicate_with_poll():
# This test was being skipped since git 25812fca8, I don't there's
# a need to do this. The original comment:
#
# https://github.com/eventlet/eventlet/pull/24 # https://github.com/eventlet/eventlet/pull/24
# `eventlet.green.subprocess.Popen.communicate()` was broken # `eventlet.green.subprocess.Popen.communicate()` was broken
# in Python 2.7 because the usage of the `select` module was moved from # in Python 2.7 because the usage of the `select` module was moved from
# `_communicate` into two other methods `_communicate_with_select` # `_communicate` into two other methods `_communicate_with_select`
# and `_communicate_with_poll`. Link to 2.7's implementation: # and `_communicate_with_poll`. Link to 2.7's implementation:
# http://hg.python.org/cpython/file/2145593d108d/Lib/subprocess.py#l1255 # http://hg.python.org/cpython/file/2145593d108d/Lib/subprocess.py#l1255
if getattr(original_subprocess.Popen, '_communicate_with_poll', None) is None:
raise SkipTest('original subprocess.Popen does not have _communicate_with_poll')
p = subprocess.Popen( p = subprocess.Popen(
[sys.executable, '-c', 'import time; time.sleep(0.5)'], [sys.executable, '-c', 'import time; time.sleep(0.5)'],