openstack/deb-python-falcon
Code Issues Proposed changes

Pull request feedback fixes

Browse Source
This commit is contained in:
Randall Burt
2013-03-18 10:21:44 -05:00
parent 4061cf4f22
commit ffca15e246
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
falcon/request.py
View File

@@ -92,7 +92,8 @@ class Request(object):
self.app = env['SCRIPT_NAME'] self.app = env['SCRIPT_NAME']
self.method = env['REQUEST_METHOD'] self.method = env['REQUEST_METHOD']
self.path = env['PATH_INFO'] or '/' self.path = env['PATH_INFO'] or '/'
# QUERY_STRING isn't required to be in env so lets check
# QUERY_STRING isn't required to be in env, so let's check
if 'QUERY_STRING' in env: if 'QUERY_STRING' in env:
self.query_string = query_string = env['QUERY_STRING'] self.query_string = query_string = env['QUERY_STRING']
else: else:

5
tests/test_req_vars.py
View File

@@ -22,10 +22,9 @@ class TestReqVars(testing.TestSuite):
env = testing.create_environ() env = testing.create_environ()
if 'QUERY_STRING' in env: if 'QUERY_STRING' in env:
del env['QUERY_STRING'] del env['QUERY_STRING']
# should not cause an exception when Request instantiated
# Should not cause an exception when Request instantiated
req = Request(env) req = Request(env)
# just make sure we don't cause regression
self.assertIsNone(req.get_param("foo"))
def test_reconstruct_url(self): def test_reconstruct_url(self):
req = self.req req = self.req