7bd27140ef
Tune performance of the Request.access_route property, while also making error handling more consistent, in the case that a header value is malformed. Also, add a test to ensure that wsgiref passes REMOTE_ADDR in the environment dict, as has been observed in production WSGI servers. This is necessary to ensure that Request.access_route's fallback to REMOTE_ADDR makes sense.
83 lines
3.0 KiB
Python
83 lines
3.0 KiB
Python
from falcon.request import Request
|
|
import falcon.testing as testing
|
|
|
|
|
|
class TestAccessRoute(testing.TestBase):
|
|
|
|
def test_remote_addr_only(self):
|
|
req = Request(testing.create_environ(
|
|
host='example.com',
|
|
path='/access_route',
|
|
headers={
|
|
'Forwarded': ('for=192.0.2.43, for="[2001:db8:cafe::17]:555",'
|
|
'for="unknown", by=_hidden,for="\\"\\\\",'
|
|
'for="198\\.51\\.100\\.17\\:1236";'
|
|
'proto=https;host=example.com')
|
|
}))
|
|
self.assertEqual(req.remote_addr, '127.0.0.1')
|
|
|
|
def test_rfc_forwarded(self):
|
|
req = Request(testing.create_environ(
|
|
host='example.com',
|
|
path='/access_route',
|
|
headers={
|
|
'Forwarded': ('for=192.0.2.43,for=,'
|
|
'for="[2001:db8:cafe::17]:555",'
|
|
'for=x,'
|
|
'for="unknown", by=_hidden,for="\\"\\\\",'
|
|
'for="_don\\\"t_\\try_this\\\\at_home_\\42",'
|
|
'for="198\\.51\\.100\\.17\\:1236";'
|
|
'proto=https;host=example.com')
|
|
}))
|
|
compares = ['192.0.2.43', '2001:db8:cafe::17', 'x',
|
|
'unknown', '"\\', '_don"t_try_this\\at_home_42',
|
|
'198.51.100.17']
|
|
self.assertEqual(req.access_route, compares)
|
|
# test cached
|
|
self.assertEqual(req.access_route, compares)
|
|
|
|
def test_malformed_rfc_forwarded(self):
|
|
req = Request(testing.create_environ(
|
|
host='example.com',
|
|
path='/access_route',
|
|
headers={
|
|
'Forwarded': 'for'
|
|
}))
|
|
self.assertEqual(req.access_route, [])
|
|
# test cached
|
|
self.assertEqual(req.access_route, [])
|
|
|
|
def test_x_forwarded_for(self):
|
|
req = Request(testing.create_environ(
|
|
host='example.com',
|
|
path='/access_route',
|
|
headers={
|
|
'X-Forwarded-For': ('192.0.2.43, 2001:db8:cafe::17,'
|
|
'unknown, _hidden, 203.0.113.60')
|
|
}))
|
|
self.assertEqual(req.access_route,
|
|
['192.0.2.43', '2001:db8:cafe::17',
|
|
'unknown', '_hidden', '203.0.113.60'])
|
|
|
|
def test_x_real_ip(self):
|
|
req = Request(testing.create_environ(
|
|
host='example.com',
|
|
path='/access_route',
|
|
headers={
|
|
'X-Real-IP': '2001:db8:cafe::17'
|
|
}))
|
|
self.assertEqual(req.access_route, ['2001:db8:cafe::17'])
|
|
|
|
def test_remote_addr(self):
|
|
req = Request(testing.create_environ(
|
|
host='example.com',
|
|
path='/access_route'))
|
|
self.assertEqual(req.access_route, ['127.0.0.1'])
|
|
|
|
def test_remote_addr_missing(self):
|
|
env = testing.create_environ(host='example.com', path='/access_route')
|
|
del env['REMOTE_ADDR']
|
|
|
|
req = Request(env)
|
|
self.assertEqual(req.access_route, [])
|