diff --git a/fuelclient/objects/plugins.py b/fuelclient/objects/plugins.py index 317b878..ce3ed10 100644 --- a/fuelclient/objects/plugins.py +++ b/fuelclient/objects/plugins.py @@ -420,8 +420,7 @@ class Plugins(base.BaseObject): if resp_raw.status_code == 409 and force: # Replace plugin information url = cls.class_instance_path.format(id=resp['id']) - resp_raw = cls.connection.put_request(url, metadata) - resp = resp_raw.json() + resp = cls.connection.put_request(url, metadata) else: resp_raw.raise_for_status() diff --git a/fuelclient/tests/test_plugins_object.py b/fuelclient/tests/test_plugins_object.py index 1fef893..b556aa9 100644 --- a/fuelclient/tests/test_plugins_object.py +++ b/fuelclient/tests/test_plugins_object.py @@ -347,11 +347,13 @@ class TestPluginsObject(base.UnitTestCase): return_value=MagicMock( status_code=409, **{'json.return_value': {'id': 99}})) - @patch.object(Plugins.connection, 'put_request') + @patch.object(Plugins.connection, 'put_request', return_value='put_return') def test_update_or_create_updates_with_force( self, put_mock, post_mock, get_for_update_mock): meta = {'id': 99, 'version': '1.0.0', 'package_version': '2.0.0'} - self.plugin.update_or_create(meta, force=True) + self.assertEqual( + self.plugin.update_or_create(meta, force=True), + 'put_return') post_mock.assert_called_once_with('plugins/', meta) get_for_update_mock.assert_called_once_with(meta) put_mock.assert_called_once_with('plugins/99', meta)