openstack/deb-python-hacking
Code Issues Proposed changes

Merge "Make H202 work again"

Browse Source
This commit is contained in:
Jenkins
2013-07-30 00:30:55 +00:00
committed by Gerrit Code Review
parent 8458dbf644 bbfd3f6a4e
commit ee48144fea
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hacking/core.py
View File

@@ -233,11 +233,11 @@ def hacking_except_format_assert(logical_line):
OpenStack HACKING guide recommends not using assertRaises(Exception...):
Do not use overly broad Exception type
Okay: self.assertRaises(NovaException)
Okay: self.assertRaises(ExceptionStrangeNotation)
H202: self.assertRaises(Exception)
Okay: self.assertRaises(NovaException, foo)
Okay: self.assertRaises(ExceptionStrangeNotation, foo)
H202: self.assertRaises(Exception, foo)
"""
if logical_line.startswith("self.assertRaises(Exception)"):
if logical_line.startswith("self.assertRaises(Exception,"):
yield 1, "H202: assertRaises Exception too broad"