openstack/deb-python-httpretty
Code Issues Proposed changes

Merge pull request #165 from akun/master

Browse Source 
Fixed an error when "Content-Length" is not int like
This commit is contained in:
Gabriel Falcão 2017-02-16 17:25:01 -05:00 committed by GitHub
commit 6d26203673
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
httpretty/core.py
View File

@ -622,6 +622,7 @@ class Entry(BaseClass):
if got is None: if got is None:
continue continue
igot = None
try: try:
igot = int(got) igot = int(got)
except (ValueError, TypeError): except (ValueError, TypeError):
@ -630,7 +631,7 @@ class Entry(BaseClass):
'with "%r" which is not a number' % got) 'with "%r" which is not a number' % got)
return return
if igot > self.body_length: if igot and igot > self.body_length:
raise HTTPrettyError( raise HTTPrettyError(
'HTTPretty got inconsistent parameters. The header ' 'HTTPretty got inconsistent parameters. The header '
'Content-Length you registered expects size "%d" but ' 'Content-Length you registered expects size "%d" but '

2
tests/functional/test_urllib2.py
View File

@ -133,6 +133,7 @@ def test_httpretty_should_allow_forcing_headers_urllib2():
body="this is supposed to be the response", body="this is supposed to be the response",
forcing_headers={ forcing_headers={
'Content-Type': 'application/xml', 'Content-Type': 'application/xml',
'Content-Length': '35a',
}) })
request = urlopen('http://github.com') request = urlopen('http://github.com')
@ -141,6 +142,7 @@ def test_httpretty_should_allow_forcing_headers_urllib2():
expect(headers).to.equal({ expect(headers).to.equal({
'content-type': 'application/xml', 'content-type': 'application/xml',
'content-length': '35a',
}) })