From b369c2372b5cd15e55933919d306cbae93da8c27 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20K=C3=B6gl?= Date: Fri, 12 Jul 2013 19:40:27 +0200 Subject: [PATCH] refactor type check --- jsonpatch.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/jsonpatch.py b/jsonpatch.py index ae2fbef..c9dcd3c 100644 --- a/jsonpatch.py +++ b/jsonpatch.py @@ -366,6 +366,11 @@ class AddOperation(PatchOperation): value = self.operation["value"] subobj, part = self.pointer.to_last(obj) + # type is already checked in to_last(), so we assert here + # for consistency + assert isinstance(subobj, list) or isinstance(subobj, dict), \ + "invalid document type %s" (type(doc),) + if isinstance(subobj, list): if part == '-': @@ -385,10 +390,6 @@ class AddOperation(PatchOperation): else: subobj[part] = value - else: - raise JsonPatchConflict("can't add to type '%s'" - "" % subobj.__class__.__name__) - return obj