openstack/deb-python-kafka
Code Issues Proposed changes

Fixup doc references to max_in_flight_requests_per_connection

Browse Source
This commit is contained in:
Dana Powers
2016-09-20 17:03:38 -07:00
parent 7690b1ab32
commit 07e09c1c2e
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kafka/conn.py
View File

@@ -557,7 +557,7 @@ class BrokerConnection(object):
return future return future
def can_send_more(self): def can_send_more(self):
"""Return True unless there are max_in_flight_requests.""" """Return True unless there are max_in_flight_requests_per_connection."""
max_ifrs = self.config['max_in_flight_requests_per_connection'] max_ifrs = self.config['max_in_flight_requests_per_connection']
return len(self.in_flight_requests) < max_ifrs return len(self.in_flight_requests) < max_ifrs

2
kafka/producer/kafka.py
View File

@@ -122,7 +122,7 @@ class KafkaProducer(object):
to resend any record whose send fails with a potentially transient to resend any record whose send fails with a potentially transient
error. Note that this retry is no different than if the client error. Note that this retry is no different than if the client
resent the record upon receiving the error. Allowing retries resent the record upon receiving the error. Allowing retries
without setting max_in_flight_connections_per_connection to 1 will without setting max_in_flight_requests_per_connection to 1 will
potentially change the ordering of records because if two batches potentially change the ordering of records because if two batches
are sent to a single partition, and the first fails and is retried are sent to a single partition, and the first fails and is retried
but the second succeeds, then the records in the second batch may but the second succeeds, then the records in the second batch may

2
kafka/producer/record_accumulator.py
View File

@@ -354,7 +354,7 @@ class RecordAccumulator(object):
* There is at least one partition that is not backing off its send * There is at least one partition that is not backing off its send
* and those partitions are not muted (to prevent reordering if * and those partitions are not muted (to prevent reordering if
max_in_flight_connections is set to 1) max_in_flight_requests_per_connection is set to 1)
* and any of the following are true: * and any of the following are true:
* The record set is full * The record set is full