openstack/deb-python-kafka
Code Issues Proposed changes

Update ClusterMetadata comments

Browse Source
This commit is contained in:
Dana Powers
2016-02-15 16:19:50 -08:00
parent b4c36ee3d3
commit 15b4b402ea
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
kafka/cluster.py
View File

@@ -22,10 +22,10 @@ class ClusterMetadata(object):
}
def __init__(self, **configs):
self._brokers = {}
self._partitions = {}
self._broker_partitions = collections.defaultdict(set)
self._groups = {}
self._brokers = {} # node_id -> BrokerMetadata
self._partitions = {} # topic -> partition -> PartitionMetadata
self._broker_partitions = collections.defaultdict(set) # node_id -> {TopicPartition...}
self._groups = {} # group_name -> node_id
self._last_refresh_ms = 0
self._last_successful_refresh_ms = 0
self._need_update = False
@@ -126,8 +126,6 @@ class ClusterMetadata(object):
node_id: BrokerMetadata(node_id, host, port)
})
# Drop any UnknownTopic, InvalidTopic, and TopicAuthorizationFailed
# but retain LeaderNotAvailable because it means topic is initializing
self._partitions.clear()
self._broker_partitions.clear()
self.unauthorized_topics.clear()
@@ -141,7 +139,9 @@ class ClusterMetadata(object):
topic=topic, partition=partition, leader=leader,
replicas=replicas, isr=isr, error=p_error)
if leader != -1:
self._broker_partitions[leader].add(TopicPartition(topic, partition))
self._broker_partitions[leader].add(
TopicPartition(topic, partition))
elif error_type is Errors.LeaderNotAvailableError:
log.error("Topic %s is not available during auto-create"
" initialization", topic)