openstack/deb-python-kafka
Code Issues Proposed changes

Fixup: _send_offset_commit_request future should succeed w/ True, not None

Browse Source
This commit is contained in:
Dana Powers
2016-02-02 08:01:45 -08:00
parent b60df8d174
commit 1fabef18bf
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kafka/coordinator/consumer.py
View File

@@ -399,7 +399,8 @@ class ConsumerCoordinator(BaseCoordinator):
assert all(map(lambda v: isinstance(v, OffsetAndMetadata), assert all(map(lambda v: isinstance(v, OffsetAndMetadata),
offsets.values())) offsets.values()))
if not offsets: if not offsets:
return Future().success(None) log.debug('No offsets to commit')
return Future().success(True)
if self.config['api_version'] >= (0, 8, 2): if self.config['api_version'] >= (0, 8, 2):
if self.coordinator_unknown(): if self.coordinator_unknown():