From 20776539f0277cb09f7447ffefe440d1bf231ef4 Mon Sep 17 00:00:00 2001 From: Omar Ghishan Date: Tue, 7 Jan 2014 17:27:21 -0800 Subject: [PATCH] Remove unnecessary method --- kafka/conn.py | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/kafka/conn.py b/kafka/conn.py index 4749bdd..b2916ce 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -61,21 +61,6 @@ class KafkaConnection(local): return resp - def _consume_response(self): - """ - This method handles the response header and error messages. It - then returns the response - """ - log.debug("Expecting response from Kafka") - # Read the size off of the header - resp = self._read_bytes(4) - - (size,) = struct.unpack('>i', resp) - - # Read the remainder of the response - resp = self._read_bytes(size) - return str(resp) - ################## # Public API # ################## @@ -100,8 +85,14 @@ class KafkaConnection(local): Get a response from Kafka """ log.debug("Reading response %d from Kafka" % request_id) - self.data = self._consume_response() - return self.data + # Read the size off of the header + resp = self._read_bytes(4) + + (size,) = struct.unpack('>i', resp) + + # Read the remainder of the response + resp = self._read_bytes(size) + return str(resp) def copy(self): """