From 2f75169504c8bd6f31ab4a88823a8073eb57eced Mon Sep 17 00:00:00 2001 From: Jeff Widman Date: Fri, 7 Jul 2017 11:32:25 -0700 Subject: [PATCH] Use logging's built-in string interpolation --- kafka/conn.py | 8 ++++---- kafka/producer/base.py | 3 +-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/kafka/conn.py b/kafka/conn.py index f118345..782783c 100644 --- a/kafka/conn.py +++ b/kafka/conn.py @@ -247,12 +247,12 @@ class BrokerConnection(object): socket.AF_UNSPEC, socket.SOCK_STREAM) except socket.gaierror as ex: - log.warning('DNS lookup failed for {0}:{1},' - ' exception was {2}. Is your' + log.warning('DNS lookup failed for %s:%d,' + ' exception was %s. Is your' ' advertised.listeners (called' ' advertised.host.name before Kafka 9)' - ' correct and resolvable?'.format( - self._init_host, self._init_port, ex)) + ' correct and resolvable?', + self._init_host, self._init_port, ex) self._gai = [] self._gai_index = 0 else: diff --git a/kafka/producer/base.py b/kafka/producer/base.py index 8d067aa..c038bd3 100644 --- a/kafka/producer/base.py +++ b/kafka/producer/base.py @@ -217,8 +217,7 @@ def _send_upstream(queue, client, codec, batch_time, batch_size, else hash(orig_req.messages)) if request_tries or not queue.empty(): - log.error('Stopped producer with {0} unsent messages' - .format(len(request_tries) + queue.qsize())) + log.error('Stopped producer with %d unsent messages', len(request_tries) + queue.qsize()) class Producer(object):