openstack/deb-python-kafka
Code Issues Proposed changes

Avoid some exceptions in Coordinator.__del__

Browse Source
This commit is contained in:
Dana Powers
2016-04-25 11:59:38 -07:00
parent 1bc2ce0778
commit 37cffc3327
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kafka/coordinator/base.py
View File

@@ -89,7 +89,8 @@ class BaseCoordinator(object):
#self.sensors = GroupCoordinatorMetrics(metrics, metric_group_prefix, metric_tags) #self.sensors = GroupCoordinatorMetrics(metrics, metric_group_prefix, metric_tags)
def __del__(self): def __del__(self):
self.heartbeat_task.disable() if hasattr(self, 'heartbeat_task') and self.heartbeat_task:
self.heartbeat_task.disable()
@abc.abstractmethod @abc.abstractmethod
def protocol_type(self): def protocol_type(self):

3
kafka/coordinator/consumer.py
View File

@@ -106,7 +106,8 @@ class ConsumerCoordinator(BaseCoordinator):
def __del__(self): def __del__(self):
if hasattr(self, '_auto_commit_task') and self._auto_commit_task: if hasattr(self, '_auto_commit_task') and self._auto_commit_task:
self._auto_commit_task.disable() self._auto_commit_task.disable()
self._cluster.remove_listener(WeakMethod(self._handle_metadata_update)) if hasattr(self, '_cluster') and self._cluster:
self._cluster.remove_listener(WeakMethod(self._handle_metadata_update))
def protocol_type(self): def protocol_type(self):
return ConsumerProtocol.PROTOCOL_TYPE return ConsumerProtocol.PROTOCOL_TYPE