Add python-snappy to tox dependencies. Fix snappy protocol test

test/test_protocol.py

@@ -65,6 +65,7 @@ class TestProtocol(unittest.TestCase):
         self.assertEqual(msg.attributes, KafkaProtocol.ATTRIBUTE_CODEC_MASK &
                                          KafkaProtocol.CODEC_SNAPPY)
         self.assertEqual(msg.key, None)
+        decoded = snappy_decode(msg.value)
         expect = "".join([
             struct.pack(">q", 0),          # MsgSet offset
             struct.pack(">i", 16),         # MsgSet size
@@ -83,7 +84,7 @@ class TestProtocol(unittest.TestCase):
             "v2",                          # Message contents
         ])
 
-        self.assertEqual(msg.value, expect)
+        self.assertEqual(decoded, expect)
 
     def test_encode_message_header(self):
         expect = "".join([
@@ -202,12 +203,16 @@ class TestProtocol(unittest.TestCase):
                         '\x80$wu\x1aW\x05\x92\x9c\x11\x00z\xc0h\x888\x00\x00'
                         '\x00')
         offset = 11
-        decoded = list(KafkaProtocol._decode_message(gzip_encoded, offset))
+        messages = list(KafkaProtocol._decode_message(gzip_encoded, offset))
-        self.assertEqual(len(decoded), 2)
+
-        (returned_offset1, decoded_message1) = decoded[0]
+        self.assertEqual(len(messages), 2)
+        msg1, msg2 = messages
+
+        returned_offset1, decoded_message1 = msg1
         self.assertEqual(returned_offset1, 0)
         self.assertEqual(decoded_message1, create_message("v1"))
-        (returned_offset2, decoded_message2) = decoded[1]
+
+        returned_offset2, decoded_message2 = msg2
         self.assertEqual(returned_offset2, 0)
         self.assertEqual(decoded_message2, create_message("v2"))
 
@@ -218,12 +223,16 @@ class TestProtocol(unittest.TestCase):
                           '\xff\xff\xff\x00\x00\x00\x02v1\x19\x1bD\x00\x10\xd5'
                           '\x96\nx\x00\x00\xff\xff\xff\xff\x00\x00\x00\x02v2')
         offset = 11
-        decoded = list(KafkaProtocol._decode_message(snappy_encoded, offset))
+        messages = list(KafkaProtocol._decode_message(snappy_encoded, offset))
-        self.assertEqual(len(decoded), 2)
+        self.assertEqual(len(messages), 2)
-        (returned_offset1, decoded_message1) = decoded[0]
+
+        msg1, msg2 = messages
+
+        returned_offset1, decoded_message1 = msg1
         self.assertEqual(returned_offset1, 0)
         self.assertEqual(decoded_message1, create_message("v1"))
-        (returned_offset2, decoded_message2) = decoded[1]
+
+        returned_offset2, decoded_message2 = msg2
         self.assertEqual(returned_offset2, 0)
         self.assertEqual(decoded_message2, create_message("v2"))
 

tox.ini

@@ -5,6 +5,7 @@ deps =
     nose
     coverage
     mock
+    python-snappy
 commands =
     nosetests --with-coverage --cover-erase --cover-package kafka []
 setenv =