openstack/deb-python-kafka
Code Issues Proposed changes

Reset consumer fields to original values rather than defaults in FetchContext

Browse Source
This commit is contained in:
Omar Ghishan
2013-12-18 17:56:29 -08:00
parent 4d6bafae7e
commit 5dd8d81c9e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
kafka/consumer.py
View File

@@ -40,6 +40,8 @@ class FetchContext(object):
def __enter__(self): def __enter__(self):
"""Set fetch values based on blocking status""" """Set fetch values based on blocking status"""
self.orig_fetch_max_wait_time = self.consumer.fetch_max_wait_time
self.orig_fetch_min_bytes = self.consumer.fetch_min_bytes
if self.block: if self.block:
self.consumer.fetch_max_wait_time = self.timeout self.consumer.fetch_max_wait_time = self.timeout
self.consumer.fetch_min_bytes = 1 self.consumer.fetch_min_bytes = 1
@@ -47,9 +49,9 @@ class FetchContext(object):
self.consumer.fetch_min_bytes = 0 self.consumer.fetch_min_bytes = 0
def __exit__(self, type, value, traceback): def __exit__(self, type, value, traceback):
"""Reset values to default""" """Reset values"""
self.consumer.fetch_max_wait_time = FETCH_MAX_WAIT_TIME self.consumer.fetch_max_wait_time = self.orig_fetch_max_wait_time
self.consumer.fetch_min_bytes = FETCH_MIN_BYTES self.consumer.fetch_min_bytes = self.orig_fetch_min_bytes
class Consumer(object): class Consumer(object):