openstack/deb-python-kafka
Code Issues Proposed changes

Catch response decode errors and log details (#715)

Browse Source
This commit is contained in:
Dana Powers
2016-06-01 16:48:43 -07:00
parent 007b2e3836
commit 644a1141b0
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
kafka/conn.py
View File

@@ -507,7 +507,20 @@ class BrokerConnection(object):
return None return None
# decode response # decode response
response = ifr.response_type.decode(read_buffer) try:
response = ifr.response_type.decode(read_buffer)
except ValueError:
read_buffer.seek(0)
buf = read_buffer.read()
log.error('%s Response %d [ResponseType: %s Request: %s]:'
' Unable to decode %d-byte buffer: %r', self,
ifr.correlation_id, ifr.response_type,
ifr.request, len(buf), buf)
ifr.future.failure(Errors.UnknownError('Unable to decode response'))
self.close()
self._processing = False
return None
log.debug('%s Response %d: %s', self, ifr.correlation_id, response) log.debug('%s Response %d: %s', self, ifr.correlation_id, response)
ifr.future.success(response) ifr.future.success(response)
self._processing = False self._processing = False