openstack/deb-python-kafka
Code Issues Proposed changes

Handle starting/stopping Kafka brokers that are already started/stopped in integration tests

Browse Source 
If some of the tests stop brokers then error out, the teardown method will try to close the
same brokers and fail. This change allows it to continue.
This commit is contained in:
Omar Ghishan
2014-01-03 15:52:37 -08:00
parent bbd90e12ff
commit 6d2b28a59e
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/fixtures.py
View File

@@ -272,8 +272,13 @@ class KafkaFixture(object):
self.tmp_dir = None self.tmp_dir = None
self.child = None self.child = None
self.running = False
def open(self): def open(self):
if self.running:
print("*** Kafka instance already running")
return
self.tmp_dir = tempfile.mkdtemp() self.tmp_dir = tempfile.mkdtemp()
print("*** Running local Kafka instance") print("*** Running local Kafka instance")
print(" host = %s" % self.host) print(" host = %s" % self.host)
@@ -318,10 +323,16 @@ class KafkaFixture(object):
self.child.start() self.child.start()
self.child.wait_for(r"\[Kafka Server %d\], Started" % self.broker_id) self.child.wait_for(r"\[Kafka Server %d\], Started" % self.broker_id)
print("*** Done!") print("*** Done!")
self.running = True
def close(self): def close(self):
if not self.running:
print("*** Kafka instance already stopped")
return
print("*** Stopping Kafka...") print("*** Stopping Kafka...")
self.child.stop() self.child.stop()
self.child = None self.child = None
print("*** Done!") print("*** Done!")
shutil.rmtree(self.tmp_dir) shutil.rmtree(self.tmp_dir)
self.running = False