openstack/deb-python-kafka
Code Issues Proposed changes

Remove recursive client.poll call in ConsumerCoordinator

Browse Source
This commit is contained in:
Dana Powers
2015-12-29 15:46:50 -08:00
parent ac57ada2bd
commit 6dea93dfdb
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kafka/coordinator/consumer.py
View File

@@ -182,9 +182,10 @@ class ConsumerCoordinator(AbstractCoordinator):
# the leader will begin watching for changes to any of the topics # the leader will begin watching for changes to any of the topics
# the group is interested in, which ensures that all metadata changes # the group is interested in, which ensures that all metadata changes
# will eventually be seen # will eventually be seen
# Because assignment typically happens within response callbacks,
# we cannot block on metadata updates here (no recursion into poll())
self._subscription.group_subscribe(all_subscribed_topics) self._subscription.group_subscribe(all_subscribed_topics)
future = self._client.set_topics(self._subscription.group_subscription()) self._client.set_topics(self._subscription.group_subscription())
self._client.poll(future=future)
log.debug("Performing %s assignment for subscriptions %s", log.debug("Performing %s assignment for subscriptions %s",
assignor.name, member_metadata) assignor.name, member_metadata)