openstack/deb-python-kafka
Code Issues Proposed changes

Change auto_commit to False in SimpleConsumer

Browse Source 
Also start a change log for important stuff like this

Closes #34
This commit is contained in:
David Arthur
2013-06-25 09:18:31 -04:00
parent 64b757868a
commit 7a5eed9f1f
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@@ -4,3 +4,4 @@
build build
dist dist
MANIFEST MANIFEST
env

3
CHANGES.md Normal file
View File

@@ -0,0 +1,3 @@
# Notable Changes
* Changing auto_commit to False in [SimpleConsumer](kafka/SimpleConsumer.py), until 0.8.1 is release offset commits are unsupported

2
kafka/consumer.py
View File

@@ -38,7 +38,7 @@ class SimpleConsumer(object):
these triggers these triggers
""" """
def __init__(self, client, group, topic, auto_commit=True, def __init__(self, client, group, topic, auto_commit=False,
auto_commit_every_n=AUTO_COMMIT_MSG_COUNT, auto_commit_every_n=AUTO_COMMIT_MSG_COUNT,
auto_commit_every_t=AUTO_COMMIT_INTERVAL): auto_commit_every_t=AUTO_COMMIT_INTERVAL):
self.client = client self.client = client