openstack/deb-python-kafka
Code Issues Proposed changes

Simplify RecordMetadata; short circuit callbacks (#768)

Browse Source 
Simplify RecordMetadata to unaltered namedtuple -- minor speed optimization
  Minor optimization: inline check for no callbacks
This commit is contained in:
Dana Powers
2016-07-17 10:17:10 -07:00
committed by GitHub
parent ade3160a4b
commit 87648d74f4
2 changed files with 9 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kafka/future.py
View File

@@ -30,7 +30,8 @@ class Future(object):
assert not self.is_done, 'Future is already complete' assert not self.is_done, 'Future is already complete'
self.value = value self.value = value
self.is_done = True self.is_done = True
self._call_backs('callback', self._callbacks, self.value) if self._callbacks:
self._call_backs('callback', self._callbacks, self.value)
return self return self
def failure(self, e): def failure(self, e):

26
kafka/producer/future.py
View File

@@ -38,12 +38,14 @@ class FutureRecordMetadata(Future):
produce_future.add_errback(self.failure) produce_future.add_errback(self.failure)
def _produce_success(self, offset_and_timestamp): def _produce_success(self, offset_and_timestamp):
base_offset, timestamp_ms = offset_and_timestamp offset, timestamp_ms = offset_and_timestamp
if timestamp_ms is None: if timestamp_ms is None:
timestamp_ms = self.timestamp_ms timestamp_ms = self.timestamp_ms
self.success(RecordMetadata(self._produce_future.topic_partition, if offset != -1 and self.relative_offset is not None:
base_offset, timestamp_ms, offset += self.relative_offset
self.relative_offset)) tp = self._produce_future.topic_partition
metadata = RecordMetadata(tp[0], tp[1], tp, offset, timestamp_ms)
self.success(metadata)
def get(self, timeout=None): def get(self, timeout=None):
if not self.is_done and not self._produce_future.wait(timeout): if not self.is_done and not self._produce_future.wait(timeout):
@@ -55,18 +57,4 @@ class FutureRecordMetadata(Future):
return self.value return self.value
class RecordMetadata(collections.namedtuple( RecordMetadata = collections.namedtuple('RecordMetadata', 'topic partition topic_partition offset timestamp')
'RecordMetadata', 'topic partition topic_partition offset timestamp')):
def __new__(cls, tp, base_offset, timestamp, relative_offset=None):
offset = base_offset
if relative_offset is not None and base_offset != -1:
offset += relative_offset
return super(RecordMetadata, cls).__new__(cls, tp.topic, tp.partition,
tp, offset, timestamp)
def __str__(self):
return 'RecordMetadata(topic=%s, partition=%s, offset=%s)' % (
self.topic, self.partition, self.offset)
def __repr__(self):
return str(self)