openstack/deb-python-kafka
Code Issues Proposed changes

Some cleanup and easier to read test fixture output

Browse Source
This commit is contained in:
Omar Ghishan
2014-01-07 17:54:05 -08:00
parent f333e9154d
commit 9cbe45d235
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/fixtures.py
View File

@@ -209,11 +209,11 @@ class ZookeeperFixture(object):
self.child = None self.child = None
def out(self, message): def out(self, message):
print("*** Zookeeper[%s]: %s" % (id(self), message)) print("*** Zookeeper [%s:%d]: %s" % (self.host, self.port, message))
def open(self): def open(self):
self.tmp_dir = tempfile.mkdtemp() self.tmp_dir = tempfile.mkdtemp()
print("*** [%s] Running local Zookeeper instance..." % id(self)) self.out("Running local instance...")
print(" host = %s" % self.host) print(" host = %s" % self.host)
print(" port = %s" % self.port) print(" port = %s" % self.port)
print(" tmp_dir = %s" % self.tmp_dir) print(" tmp_dir = %s" % self.tmp_dir)
@@ -278,7 +278,7 @@ class KafkaFixture(object):
self.running = False self.running = False
def out(self, message): def out(self, message):
print("*** Kafka[%s]: %s" % (id(self), message)) print("*** Kafka [%s:%d]: %s" % (self.host, self.port, message))
def open(self): def open(self):
if self.running: if self.running:
@@ -286,7 +286,7 @@ class KafkaFixture(object):
return return
self.tmp_dir = tempfile.mkdtemp() self.tmp_dir = tempfile.mkdtemp()
self.out("Running local instance") self.out("Running local instance...")
print(" host = %s" % self.host) print(" host = %s" % self.host)
print(" port = %s" % self.port) print(" port = %s" % self.port)
print(" broker_id = %s" % self.broker_id) print(" broker_id = %s" % self.broker_id)

2
test/test_integration.py
View File

@@ -8,7 +8,7 @@ import random
from kafka import * # noqa from kafka import * # noqa
from kafka.common import * # noqa from kafka.common import * # noqa
from kafka.codec import has_gzip, has_snappy from kafka.codec import has_gzip, has_snappy
from kafka.consumer import FETCH_BUFFER_SIZE_BYTES, MAX_FETCH_BUFFER_SIZE_BYTES from kafka.consumer import MAX_FETCH_BUFFER_SIZE_BYTES
from .fixtures import ZookeeperFixture, KafkaFixture from .fixtures import ZookeeperFixture, KafkaFixture