openstack/deb-python-kafka
Code Issues Proposed changes

Update kafka.util.crc32 to unsigned everywhere

Browse Source
This commit is contained in:
Mark Roberts
2014-09-03 19:21:35 -07:00
parent 84a7add6da
commit be23042ecd
2 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kafka/protocol.py
View File

@@ -98,7 +98,7 @@ class KafkaProtocol(object):
msg += write_int_string(message.key)
msg += write_int_string(message.value)
crc = crc32(msg)
msg = struct.pack('>i%ds' % len(msg), crc, msg)
msg = struct.pack('>I%ds' % len(msg), crc, msg)
else:
raise ProtocolError("Unexpected magic number: %d" % message.magic)
return msg
@@ -148,7 +148,7 @@ class KafkaProtocol(object):
The offset is actually read from decode_message_set_iter (it is part
of the MessageSet payload).
"""
((crc, magic, att), cur) = relative_unpack('>iBB', data, 0)
((crc, magic, att), cur) = relative_unpack('>IBB', data, 0)
if crc != crc32(data[4:]):
raise ChecksumError("Message checksum failed")