From c4a6e1aa68fc48dd589ff64e1247d2886ccfa3fd Mon Sep 17 00:00:00 2001 From: Dana Powers Date: Sun, 20 Nov 2016 12:44:55 -0800 Subject: [PATCH] Use six.string_types for topic type check in #824 --- kafka/consumer/subscription_state.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kafka/consumer/subscription_state.py b/kafka/consumer/subscription_state.py index 4366010..9e7f080 100644 --- a/kafka/consumer/subscription_state.py +++ b/kafka/consumer/subscription_state.py @@ -133,7 +133,7 @@ class SubscriptionState(object): if self._user_assignment: raise IllegalStateError(self._SUBSCRIPTION_EXCEPTION_MESSAGE) - if isinstance(topics, str): + if isinstance(topics, six.string_types): topics = [topics] if self.subscription == set(topics): @@ -141,7 +141,7 @@ class SubscriptionState(object): topics) return - if any(not isinstance(t, str) for t in topics): + if any(not isinstance(t, six.string_types) for t in topics): raise TypeError('All topics must be strings') log.info('Updating subscribed topics to: %s', topics)