openstack/deb-python-kafka
Code Issues Proposed changes

Send combined size and payload bytes to socket to avoid potentially split packets with TCP_NODELAY (#797)

Browse Source
This commit is contained in:
Dana Powers
2016-08-04 18:30:45 -07:00
committed by GitHub
parent b24a5c25ae
commit d3d3ad8b74
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kafka/conn.py
View File

@@ -519,12 +519,12 @@ class BrokerConnection(object):
client_id=self.config['client_id']) client_id=self.config['client_id'])
message = b''.join([header.encode(), request.encode()]) message = b''.join([header.encode(), request.encode()])
size = Int32.encode(len(message)) size = Int32.encode(len(message))
data = size + message
try: try:
# In the future we might manage an internal write buffer # In the future we might manage an internal write buffer
# and send bytes asynchronously. For now, just block # and send bytes asynchronously. For now, just block
# sending each request payload # sending each request payload
self._sock.setblocking(True) self._sock.setblocking(True)
for data in (size, message):
total_sent = 0 total_sent = 0
while total_sent < len(data): while total_sent < len(data):
sent_bytes = self._sock.send(data[total_sent:]) sent_bytes = self._sock.send(data[total_sent:])