openstack/deb-python-kafka
Code Issues Proposed changes

KafkaClient: log responses by requestId for debugging

Browse Source
This commit is contained in:
Dana Powers
2015-06-09 21:57:26 -07:00
parent bedaafa804
commit d6585483e0
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kafka/client.py
View File

@@ -189,10 +189,12 @@ class KafkaClient(object):
# No exception, try to get response # No exception, try to get response
else: else:
# decoder_fn=None signal that the server is expected to not # decoder_fn=None signal that the server is expected to not
# send a response. This probably only applies to # send a response. This probably only applies to
# ProduceRequest w/ acks = 0 # ProduceRequest w/ acks = 0
if decoder_fn is None: if decoder_fn is None:
log.debug('Request %s does not expect a response '
'(skipping conn.recv)', requestId)
for payload in payloads: for payload in payloads:
responses_by_broker[broker].append(None) responses_by_broker[broker].append(None)
continue continue
@@ -211,6 +213,7 @@ class KafkaClient(object):
else: else:
for payload_response in decoder_fn(response): for payload_response in decoder_fn(response):
responses_by_broker[broker].append(payload_response) responses_by_broker[broker].append(payload_response)
log.debug('Response %s: %s', requestId, responses_by_broker[broker])
# Connection errors generally mean stale metadata # Connection errors generally mean stale metadata
# although sometimes it means incorrect api request # although sometimes it means incorrect api request