openstack/deb-python-kafka
Code Issues Proposed changes

Update Sensor time_ms docs; only calculate if needed

Browse Source
This commit is contained in:
Dana Powers
2016-07-10 21:41:23 -07:00
parent 9b5c5acd9a
commit dbb0dae4f3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
kafka/metrics/stats/sensor.py
View File

@@ -55,15 +55,15 @@ class Sensor(object):
Record a value at a known time. Record a value at a known time.
Arguments: Arguments:
value (double): The value we are recording value (double): The value we are recording
time_ms (int): The current POSIX time in milliseconds time_ms (int): A POSIX timestamp in milliseconds.
Default: The time when record() is evaluated (now)
Raises: Raises:
QuotaViolationException: if recording this value moves a QuotaViolationException: if recording this value moves a
metric beyond its configured maximum or minimum bound metric beyond its configured maximum or minimum bound
""" """
now = time.time() * 1000
if time_ms is None: if time_ms is None:
time_ms = now time_ms = time.time() * 1000
self._last_record_time = time_ms self._last_record_time = time_ms
with self._lock: # XXX high volume, might be performance issue with self._lock: # XXX high volume, might be performance issue
# increment all the stats # increment all the stats