openstack/deb-python-kafka
Code Issues Proposed changes

set default config on consumer class to support subclass config changes.

Browse Source
This commit is contained in:
Zack Dever
2015-08-13 12:12:49 -07:00
parent adbd4ac052
commit e59e6cf4f6
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kafka/consumer/kafka.py
View File

@@ -53,6 +53,7 @@ DEPRECATED_CONFIG_KEYS = {
class KafkaConsumer(object):
"""A simpler kafka consumer"""
DEFAULT_CONFIG = deepcopy(DEFAULT_CONSUMER_CONFIG)
def __init__(self, *topics, **configs):
self.configure(**configs)
@@ -111,8 +112,8 @@ class KafkaConsumer(object):
"""
configs = self._deprecate_configs(**configs)
self._config = {}
for key in DEFAULT_CONSUMER_CONFIG:
self._config[key] = configs.pop(key, DEFAULT_CONSUMER_CONFIG[key])
for key in self.DEFAULT_CONFIG:
self._config[key] = configs.pop(key, self.DEFAULT_CONFIG[key])
if configs:
raise KafkaConfigurationError('Unknown configuration key(s): ' +