openstack/deb-python-kafka
Code Issues Proposed changes

Mock client.ensure_topic_exists in test_producer_sync_fail_on_error

Browse Source
This commit is contained in:
Dana Powers
2015-12-17 10:23:15 -08:00
parent 178a1dccd8
commit f89b9da1f3
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
test/test_producer.py
View File

@@ -97,19 +97,20 @@ class TestKafkaProducer(unittest.TestCase):
def test_producer_sync_fail_on_error(self): def test_producer_sync_fail_on_error(self):
error = FailedPayloadsError('failure') error = FailedPayloadsError('failure')
with patch.object(KafkaClient, 'load_metadata_for_topics'): with patch.object(KafkaClient, 'load_metadata_for_topics'):
with patch.object(KafkaClient, 'get_partition_ids_for_topic', return_value=[0, 1]): with patch.object(KafkaClient, 'ensure_topic_exists'):
with patch.object(KafkaClient, '_send_broker_aware_request', return_value = [error]): with patch.object(KafkaClient, 'get_partition_ids_for_topic', return_value=[0, 1]):
with patch.object(KafkaClient, '_send_broker_aware_request', return_value = [error]):
client = KafkaClient(MagicMock()) client = KafkaClient(MagicMock())
producer = SimpleProducer(client, async=False, sync_fail_on_error=False) producer = SimpleProducer(client, async=False, sync_fail_on_error=False)
# This should not raise # This should not raise
(response,) = producer.send_messages('foobar', b'test message') (response,) = producer.send_messages('foobar', b'test message')
self.assertEqual(response, error) self.assertEqual(response, error)
producer = SimpleProducer(client, async=False, sync_fail_on_error=True) producer = SimpleProducer(client, async=False, sync_fail_on_error=True)
with self.assertRaises(FailedPayloadsError): with self.assertRaises(FailedPayloadsError):
producer.send_messages('foobar', b'test message') producer.send_messages('foobar', b'test message')
def test_cleanup_is_not_called_on_stopped_producer(self): def test_cleanup_is_not_called_on_stopped_producer(self):
producer = Producer(MagicMock(), async=True) producer = Producer(MagicMock(), async=True)