openstack/deb-python-kafka
Code Issues Proposed changes

Cleanup new producer tests...

Browse Source
This commit is contained in:
Dana Powers
2015-12-04 17:15:49 -08:00
parent 7dec992a4e
commit fb024355f0
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/test_producer.py
View File

@@ -111,19 +111,19 @@ class TestKafkaProducer(unittest.TestCase):
with self.assertRaises(FailedPayloadsError): with self.assertRaises(FailedPayloadsError):
producer.send_messages('foobar', b'test message') producer.send_messages('foobar', b'test message')
def test_cleanup_stop_is_called_on_not_stopped_object(self): def test_cleanup_is_not_called_on_stopped_producer(self):
producer = Producer(MagicMock(), async=True) producer = Producer(MagicMock(), async=True)
producer.stopped = True producer.stopped = True
with patch('kafka.producer.base.Producer.stop') as base_stop: with patch.object(producer, 'stop') as mocked_stop:
producer._cleanup_func(producer) producer._cleanup_func(producer)
self.assertEqual(base_stop.call_count, 0) self.assertEqual(mocked_stop.call_count, 0)
def test_cleanup_stop_is_not_called_on_stopped_object(self): def test_cleanup_is_called_on_running_producer(self):
producer = Producer(MagicMock(), async=True) producer = Producer(MagicMock(), async=True)
producer.stopped = False producer.stopped = False
with patch('kafka.producer.base.Producer.stop') as base_stop: with patch.object(producer, 'stop') as mocked_stop:
producer._cleanup_func(producer) producer._cleanup_func(producer)
self.assertEqual(base_stop.call_count, 1) self.assertEqual(mocked_stop.call_count, 1)
class TestKafkaProducerSendUpstream(unittest.TestCase): class TestKafkaProducerSendUpstream(unittest.TestCase):